Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: Source/platform/fonts/shaping/SimpleShaper.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase patch Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/shaping/HarfBuzzShaper.cpp ('k') | Source/platform/network/HTTPParsers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/shaping/SimpleShaper.cpp
diff --git a/Source/platform/fonts/shaping/SimpleShaper.cpp b/Source/platform/fonts/shaping/SimpleShaper.cpp
index 6bda31c4b6a76d771fc076386455945ad1d74f52..b44a998f1da3a167dd23beff5c8a420db92bf6c8 100644
--- a/Source/platform/fonts/shaping/SimpleShaper.cpp
+++ b/Source/platform/fonts/shaping/SimpleShaper.cpp
@@ -72,7 +72,7 @@ float SimpleShaper::characterWidth(UChar32 character, const GlyphData& glyphData
const SimpleFontData* fontData = glyphData.fontData;
ASSERT(fontData);
- if (UNLIKELY(character == characterTabulation && m_run.allowTabs()))
+ if (UNLIKELY(character == tabulationCharacter && m_run.allowTabs()))
return m_font->tabWidth(*fontData, m_run.tabSize(), m_run.xPos() + m_runWidthSoFar);
float width = fontData->widthForGlyph(glyphData.glyph);
@@ -112,8 +112,8 @@ float SimpleShaper::adjustSpacing(float width, const CharacterData& charData)
// Account for word spacing.
// We apply additional space between "words" by adding width to the space character.
- if (isExpansionOpportunity && (charData.character != characterTabulation || !m_run.allowTabs())
- && (charData.characterOffset || charData.character == noBreakSpace)
+ if (isExpansionOpportunity && (charData.character != tabulationCharacter || !m_run.allowTabs())
+ && (charData.characterOffset || charData.character == noBreakSpaceCharacter)
&& m_font->fontDescription().wordSpacing()) {
width += m_font->fontDescription().wordSpacing();
}
@@ -145,7 +145,7 @@ unsigned SimpleShaper::advanceInternal(TextIterator& textIterator, GlyphBuffer*
float width;
bool spaceUsedAsZeroWidthSpace = false;
if (!glyphData.glyph && Character::treatAsZeroWidthSpace(charData.character)) {
- charData.character = space;
+ charData.character = spaceCharacter;
glyphData = glyphDataForCharacter(charData);
width = 0;
spaceUsedAsZeroWidthSpace = true;
« no previous file with comments | « Source/platform/fonts/shaping/HarfBuzzShaper.cpp ('k') | Source/platform/network/HTTPParsers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698