Source/core/layout/LayoutTreeAsText.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutTreeAsText.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutTreeAsText.cpp

diff --git a/Source/core/layout/LayoutTreeAsText.cpp b/Source/core/layout/LayoutTreeAsText.cpp

index f5fd814ef2f4131088338d586da99d890400ad2b..b5a2d739b448e67ab5c2627039c72e48e3c7c3ee 100644

--- a/Source/core/layout/LayoutTreeAsText.cpp

+++ b/Source/core/layout/LayoutTreeAsText.cpp

@@ -138,7 +138,7 @@ String quoteAndEscapeNonPrintables(const String& s)

} else if (c == '"') {

result.append('\\');

result.append('"');

- } else if (c == '\n' || c == noBreakSpace) {

+ } else if (c == '\n' || c == noBreakSpaceCharacter) {

result.append(' ');

} else {

if (c >= 0x20 && c < 0x7F) {

@@ -332,13 +332,13 @@ void LayoutTreeAsText::writeLayoutObject(TextStream& ts, const LayoutObject& o,

text = quoteAndEscapeNonPrintables(text);

} else {

switch (text[0]) {

- case bullet:

+ case bulletCharacter:

text = "bullet";

break;

- case blackSquare:

+ case blackSquareCharacter:

text = "black square";

break;

- case whiteBullet:

+ case whiteBulletCharacter:

text = "white bullet";

break;

default: