Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Unified Diff: Source/platform/fonts/FontFallbackList.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Comment fixes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/fonts/FontFallbackList.cpp
diff --git a/Source/platform/fonts/FontFallbackList.cpp b/Source/platform/fonts/FontFallbackList.cpp
index eb2fc051195eaafaa3f82e831051ff071ae90de5..9792fa274ab44a3afa73b4facf67130c286e4626 100644
--- a/Source/platform/fonts/FontFallbackList.cpp
+++ b/Source/platform/fonts/FontFallbackList.cpp
@@ -37,6 +37,8 @@
#include "wtf/unicode/CharacterNames.h"
namespace blink {
+using namespace WTF;
jsbell 2015/05/11 16:28:02 Are these using declarations necessary?
h.joshi 2015/05/12 04:20:14 Sorry for this, removed now. Was checking somethin
+using namespace Unicode;
FontFallbackList::FontFallbackList()
: m_pageZero(0)
@@ -111,17 +113,17 @@ const SimpleFontData* FontFallbackList::determinePrimarySimpleFontData(const Fon
// All fonts are custom fonts and are loading. Return the first FontData.
fontData = fontDataAt(fontDescription, 0);
if (fontData)
- return fontData->fontDataForCharacter(space);
+ return fontData->fontDataForCharacter(spaceCharacter);
SimpleFontData* lastResortFallback = FontCache::fontCache()->getLastResortFallbackFont(fontDescription).get();
ASSERT(lastResortFallback);
return lastResortFallback;
}
- if (fontData->isSegmented() && !toSegmentedFontData(fontData)->containsCharacter(space))
+ if (fontData->isSegmented() && !toSegmentedFontData(fontData)->containsCharacter(spaceCharacter))
continue;
- const SimpleFontData* fontDataForSpace = fontData->fontDataForCharacter(space);
+ const SimpleFontData* fontDataForSpace = fontData->fontDataForCharacter(spaceCharacter);
ASSERT(fontDataForSpace);
// When a custom font is loading, we should use the correct fallback font to layout the text.

Powered by Google App Engine
This is Rietveld 408576698