Source/wtf/text/WTFString.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/text/WTFString.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code changes to correct Test Expectation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/wtf/text/WTFString.cpp

diff --git a/Source/wtf/text/WTFString.cpp b/Source/wtf/text/WTFString.cpp

index f293010291a26801f8fbf7e8036446b8c1aee6f7..daeec41dc297965ff82e8579e833010e13a58a5a 100644

--- a/Source/wtf/text/WTFString.cpp

+++ b/Source/wtf/text/WTFString.cpp

@@ -800,7 +800,7 @@ CString String::utf8(UTF8ConversionMode mode) const

ASSERT((0xD800 <= *characters && *characters <= 0xDFFF));

// There should be room left, since one UChar hasn't been converted.

ASSERT((buffer + 3) <= bufferEnd);

- putUTF8Triple(buffer, replacementCharacter);

+ putUTF8Triple(buffer, characterReplacement);

++characters;

}