Source/wtf/text/StringBuilderTest.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/text/StringBuilderTest.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code changes to correct Test Expectation Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/wtf/text/StringBuilderTest.cpp

diff --git a/Source/wtf/text/StringBuilderTest.cpp b/Source/wtf/text/StringBuilderTest.cpp

index 3856f35d4521484a03c65f9bb05ec9c8a10f23d5..f898952dbc282786563ff5492814e67fa8cb1932 100644

--- a/Source/wtf/text/StringBuilderTest.cpp

+++ b/Source/wtf/text/StringBuilderTest.cpp

@@ -321,10 +321,10 @@ TEST(StringBuilderTest, AppendNumberDoubleUChar)

{

const double someNumber = 1.2345;

StringBuilder reference;

- reference.append(replacementCharacter); // Make it UTF-16.

+ reference.append(characterReplacement); // Make it UTF-16.

reference.append(String::number(someNumber));

StringBuilder test;

- test.append(replacementCharacter);

+ test.append(characterReplacement);

test.appendNumber(someNumber);

ASSERT_EQ(reference, test);

}