Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: Source/platform/text/UnicodeUtilities.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code changes to correct Test Expectation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/text/UnicodeUtilities.cpp
diff --git a/Source/platform/text/UnicodeUtilities.cpp b/Source/platform/text/UnicodeUtilities.cpp
index 7fd0cbaff0fbada7e595527d255ec61f3d8d6497..86f2127edbce6dc465bbc8e6d7a9e4e4a4989bf1 100644
--- a/Source/platform/text/UnicodeUtilities.cpp
+++ b/Source/platform/text/UnicodeUtilities.cpp
@@ -45,15 +45,15 @@ template <typename CharType>
static inline CharType foldQuoteMarkOrSoftHyphen(CharType c)
{
switch (static_cast<UChar>(c)) {
- case hebrewPunctuationGershayim:
- case leftDoubleQuotationMark:
- case rightDoubleQuotationMark:
+ case characterHebrewPunctuationGershayim:
+ case characterLeftDoubleQuotationMark:
+ case characterRightDoubleQuotationMark:
return '"';
- case hebrewPunctuationGeresh:
- case leftSingleQuotationMark:
- case rightSingleQuotationMark:
+ case characterHebrewPunctuationGeresh:
+ case characterLeftSingleQuotationMark:
+ case characterRightSingleQuotationMark:
return '\'';
- case softHyphen:
+ case characterSoftHyphen:
// Replace soft hyphen with an ignorable character so that their presence or absence will
// not affect string comparison.
return 0;
@@ -70,15 +70,15 @@ void foldQuoteMarksAndSoftHyphens(UChar* data, size_t length)
void foldQuoteMarksAndSoftHyphens(String& s)
{
- s.replace(hebrewPunctuationGeresh, '\'');
- s.replace(hebrewPunctuationGershayim, '"');
- s.replace(leftDoubleQuotationMark, '"');
- s.replace(leftSingleQuotationMark, '\'');
- s.replace(rightDoubleQuotationMark, '"');
- s.replace(rightSingleQuotationMark, '\'');
+ s.replace(characterHebrewPunctuationGeresh, '\'');
+ s.replace(characterHebrewPunctuationGershayim, '"');
+ s.replace(characterLeftDoubleQuotationMark, '"');
+ s.replace(characterLeftSingleQuotationMark, '\'');
+ s.replace(characterRightDoubleQuotationMark, '"');
+ s.replace(characterRightSingleQuotationMark, '\'');
// Replace soft hyphen with an ignorable character so that their presence or absence will
// not affect string comparison.
- s.replace(softHyphen, 0);
+ s.replace(characterSoftHyphen, 0);
}
static bool isNonLatin1Separator(UChar32 character)

Powered by Google App Engine
This is Rietveld 408576698