Source/platform/fonts/SimpleFontData.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/SimpleFontData.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code changes to correct Test Expectation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/SimpleFontData.cpp

diff --git a/Source/platform/fonts/SimpleFontData.cpp b/Source/platform/fonts/SimpleFontData.cpp

index 34b5a2c45616abb8483889f0687f279cf6cad0d1..7851551cc93bd437b5d9bdaa5c70360f32391550 100644

--- a/Source/platform/fonts/SimpleFontData.cpp

+++ b/Source/platform/fonts/SimpleFontData.cpp

@@ -283,7 +283,7 @@ void SimpleFontData::platformGlyphInit()

// Nasty hack to determine if we should round or ceil space widths.

// If the font is monospace or fake monospace we ceil to ensure that

// every character and the space are the same width. Otherwise we round.

- m_spaceGlyph = glyphPageZero->glyphForCharacter(space);

+ m_spaceGlyph = glyphPageZero->glyphForCharacter(characterSpace);

float width = widthForGlyph(m_spaceGlyph);

m_spaceWidth = width;

m_zeroGlyph = glyphPageZero->glyphForCharacter('0');