Source/core/layout/LayoutDeprecatedFlexibleBox.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code changes to correct Test Expectation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

diff --git a/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp b/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

index af6bcd29047812fc2045daacafb031ccf0485a2c..021a167b47f8b08567e5b43dd4d66df398676138 100644

--- a/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

+++ b/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

@@ -895,9 +895,9 @@ void LayoutDeprecatedFlexibleBox::applyLineClamp(FlexBoxIterator& iterator, bool

if (!lastVisibleLine)

continue;

- DEFINE_STATIC_LOCAL(AtomicString, ellipsisStr, (&horizontalEllipsis, 1));

+ DEFINE_STATIC_LOCAL(AtomicString, ellipsisStr, (&characterHorizontalEllipsis, 1));

const Font& font = style(numVisibleLines == 1)->font();

- float totalWidth = font.width(constructTextRun(this, font, &horizontalEllipsis, 1, styleRef(), style()->direction()));

+ float totalWidth = font.width(constructTextRun(this, font, &characterHorizontalEllipsis, 1, styleRef(), style()->direction()));

// See if this width can be accommodated on the last visible line

LayoutBlockFlow& destBlock = lastVisibleLine->block();