build/config/features.gni - Issue 1119613002: Fix building NaCl in Linux component GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/features.gni

Issue 1119613002: Fix building NaCl in Linux component GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/features.gni

diff --git a/build/config/features.gni b/build/config/features.gni

index dd7b0819b55e4f5258e5e6789549cbf91a645c0b..cf54c04b02e0dab3ee256c1557ca5c22f7be2d1f 100644

--- a/build/config/features.gni

+++ b/build/config/features.gni

@@ -32,8 +32,7 @@ declare_args() {

# the commented out logic.

# Eventually we want this to be:

# enable_nacl = !is_ios && !is_android

- enable_nacl =

- (is_linux && !is_chromeos && !is_debug && current_cpu == "x64") || is_nacl

+ enable_nacl = (is_linux && !is_chromeos && current_cpu == "x64") || is_nacl

Dirk Pranke 2015/04/29 22:29:26 It might be that ChromeOS works fine now, but I'll

enable_nacl_untrusted = enable_nacl

enable_pnacl = enable_nacl_untrusted