Fix building NaCl in Linux component GN builds.

Fix building NaCl in Linux component GN builds.

R=brettw@chromium.org, bbudge@chromium.org
BUG=482415
Committed: https://crrev.com/fc9e836200dfd6d40034783f25a26728219276ab
Cr-Commit-Position: refs/heads/master@{#328882}

[Dirk Pranke, 2015-04-29 22:29:26]

https://codereview.chromium.org/1119613002/diff/1/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1119613002/diff/1/build/config/features.gni#n...
build/config/features.gni:35: enable_nacl = (is_linux && !is_chromeos &&
current_cpu == "x64") || is_nacl
It might be that ChromeOS works fine now, but I'll test that separately
(different CL once this one lands). I think we still need a bit more work before
the x86 builds work.

https://codereview.chromium.org/1119613002/diff/1/content/test/BUILD.gn
File content/test/BUILD.gn (right):

https://codereview.chromium.org/1119613002/diff/1/content/test/BUILD.gn#newco...
content/test/BUILD.gn:678: "//gpu/blink",
These seem to be needed in the release component builds; I'm not sure why they
aren't needed in debug (or perhaps they are actually broken in debug at the
moment, we just don't see this because we're not building them on the bots).

[Dirk Pranke, 2015-04-29 23:15:43]

https://codereview.chromium.org/1119613002/diff/1/content/test/BUILD.gn
File content/test/BUILD.gn (right):

https://codereview.chromium.org/1119613002/diff/1/content/test/BUILD.gn#newco...
content/test/BUILD.gn:678: "//gpu/blink",
Indeed, it looks like these are broken independently of the NaCl settings, so I
could pull these out to a separate CL, but probably won't bother.

[brettw, 2015-04-30 04:45:47]

In the x86_newlib nacl toolchain in build/toolchain/nacl/BUILD.gn it has this:
    # Component build not supported in NaCl, since it does not support shared
    # libraries.
    is_component_build = false
Is this the toolchain that's being used? I think the toolchain_args thing makes
more sense to set the correct value when invoking the toolchain, rather than
trying to clobber the values in the build config file.

[Dirk Pranke, 2015-04-30 15:57:38]

On 2015/04/30 04:45:47, brettw wrote:
> In the x86_newlib nacl toolchain in build/toolchain/nacl/BUILD.gn it has this:
>     # Component build not supported in NaCl, since it does not support shared
>     # libraries.
>     is_component_build = false
> Is this the toolchain that's being used? I think the toolchain_args thing
makes
> more sense to set the correct value when invoking the toolchain, rather than
> trying to clobber the values in the build config file.

No, we're using the irt toolchain, but the suggestion makes sense. I'll give it
a try.

[Dirk Pranke, 2015-05-01 00:26:12]

Okay, things seem to work with a toolchain_args approach.

This patch will depend on https://codereview.chromium.org/1121643002/ (the NaCl
fix), since we pull most NaCl toolchains from their repo.

I don't think the toolchain in //build/toolchain/nacl is actually used, and we
should probably delete it.

[brettw, 2015-05-01 16:39:05]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-05-01 16:39:05]

lgtm

[commit-bot: I haz the power, 2015-05-01 16:39:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119613002/20001

[Dirk Pranke, 2015-05-01 16:47:50]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2015-05-01 16:48:23]

On 2015/05/01 16:39:29, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1119613002/20001

stopping the CQ ... this can't land before the NaCl fix gets rolled in, or we'd
break the debug component builds.

[bbudge, 2015-05-01 21:45:53]

lgtm

[Dirk Pranke, 2015-05-07 22:12:41]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-07 22:14:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119613002/20001

[commit-bot: I haz the power, 2015-05-07 23:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 23:41:20]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-05-07 23:43:57]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-05-07 23:44:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119613002/20001

[commit-bot: I haz the power, 2015-05-07 23:52:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-07 23:54:31]

Patchset 2 (id:??) landed as
https://crrev.com/fc9e836200dfd6d40034783f25a26728219276ab
Cr-Commit-Position: refs/heads/master@{#328882}