Issue 11196055: Disable pushState and the rest of the history API in packaged apps via runtime-enabled features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11196055: Disable pushState and the rest of the history API in packaged apps via runtime-enabled features (Closed)

Created:
8 years, 2 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 1 month ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable pushState and the rest of the history API in packaged apps via runtime-enabled features Chrome Apps do not support the history API (or navigation in general). Since pushState is generally feature detected, it's cleanest to disable it per-document, so that applications can have the appropriate fallback behavior (other history APIs are re-mapped to throw exceptions, since history.back() and the link are not feature detected). Depends on http://webkit.org/b/99780. BUG=146076 R=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164134

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -5 lines)			Patch
M	chrome/renderer/chrome_render_view_observer.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/renderer/resources/extensions/platform_app.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/platform_apps/restrictions/main.js	View	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/11196055/1

8 years, 1 month ago (2012-10-25 17:07:40 UTC) #3

Change committed as 164134

Expand Messages | Collapse Messages