Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 11196029: Test for destroying leveldb directory when we detect a schema downgrade (Closed)

Created:
8 years, 2 months ago by dgrogan
Modified:
8 years, 1 month ago
Reviewers:
jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, erikwright+watch_chromium.org, darin-cc_chromium.org, alecflett
Visibility:
Public.

Description

Test for destroying leveldb directory when we detect corruption or a schema downgrade BUG=156490, 158176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166600

Patch Set 1 #

Patch Set 2 : test works now #

Patch Set 3 : Add some comments, improve var names #

Total comments: 2

Patch Set 4 : fix nits #

Patch Set 5 : Add test for corrupt leveldb #

Patch Set 6 : rename invalid_schema to open_bad_db #

Patch Set 7 : just the tests, not data files #

Patch Set 8 : fix initializer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -27 lines) Patch
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 2 3 4 5 6 7 4 chunks +98 lines, -26 lines 0 comments Download
A + content/test/data/indexeddb/open_bad_db.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/indexeddb/open_bad_db.js View 1 2 3 4 5 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dgrogan
Josh, could you review this?
8 years, 2 months ago (2012-10-17 22:57:59 UTC) #1
jsbell
lgtm with really trivial nits. There's probably more opportunity for refactoring when we add more ...
8 years, 2 months ago (2012-10-17 23:44:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/11196029/6002
8 years, 2 months ago (2012-10-18 14:36:10 UTC) #3
commit-bot: I haz the power
Can't process patch for file content/test/data/indexeddb/schema_version_123456/file__0.indexeddb.leveldb/MANIFEST-000002. Binary file support is temporarilly disabled due to a ...
8 years, 2 months ago (2012-10-18 14:36:14 UTC) #4
jsbell
It looks like this hasn't landed yet? Please include an additional test for the case ...
8 years, 1 month ago (2012-10-29 19:16:34 UTC) #5
dgrogan
On 2012/10/29 19:16:34, jsbell wrote: > It looks like this hasn't landed yet? > > ...
8 years, 1 month ago (2012-11-06 23:00:40 UTC) #6
jsbell
lgtm
8 years, 1 month ago (2012-11-07 19:53:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/11196029/22001
8 years, 1 month ago (2012-11-08 00:05:22 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-08 00:36:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/11196029/19014
8 years, 1 month ago (2012-11-08 00:36:23 UTC) #10
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 04:38:47 UTC) #11
Change committed as 166600

Powered by Google App Engine
This is Rietveld 408576698