Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1119563002: Add hairlines batch unit test (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@randbatch3
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add hairlines batch unit test BUG=skia: Committed: https://skia.googlesource.com/skia/+/40ded3241894076237844325c015fcc724e9d443

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 2

Patch Set 3 : nits #

Patch Set 4 : rebase #

Patch Set 5 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -15 lines) Patch
M include/gpu/GrTestUtils.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 3 4 3 chunks +58 lines, -15 lines 0 comments Download
M src/gpu/GrTestUtils.cpp View 1 2 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
joshualitt
ptal
5 years, 7 months ago (2015-04-29 21:15:14 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/1119563002/diff/20001/src/gpu/GrTestUtils.cpp File src/gpu/GrTestUtils.cpp (right): https://codereview.chromium.org/1119563002/diff/20001/src/gpu/GrTestUtils.cpp#newcode125 src/gpu/GrTestUtils.cpp:125: if (!gOnce) { gOnce = true ...
5 years, 7 months ago (2015-04-30 13:39:58 UTC) #3
joshualitt
Brian, can I get a rubber stamp?
5 years, 7 months ago (2015-05-01 21:00:31 UTC) #4
bsalomon
On 2015/05/01 21:00:31, joshualitt wrote: > Brian, can I get a rubber stamp? lgtm
5 years, 7 months ago (2015-05-01 21:15:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119563002/80001
5 years, 7 months ago (2015-05-02 13:58:55 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-02 14:07:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/40ded3241894076237844325c015fcc724e9d443

Powered by Google App Engine
This is Rietveld 408576698