Issue 111953004: Allow 0-width SkBitmap in setConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111953004: Allow 0-width SkBitmap in setConfig. (Closed)

Created:
7 years ago by hal.canary

Modified:
7 years ago

Reviewers:
scroggo, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Allow 0-width SkBitmap in setConfig. Previously, SkBitmap::setConfig would allow zero height, but not zero width. This is changed for consistancy. A unit test was added. BUG= R=reed@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12673

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -1 line)			Patch
M	gyp/tests.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/BitmapTest.cpp	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

hal.canary

Tell me how this should behave. This patch makes things consistent.

7 years ago (2013-12-11 13:35:04 UTC) #1

hal.canary

7 years ago (2013-12-13 18:29:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r12673 (presubmit successful).