Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1119513002: Apply automated fixits for Chrome clang plugin to device. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
keybuk, Nico
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to device. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=keybuk@chromium.org Committed: https://crrev.com/75727f2f2a3196e77c3c14ee4647ed0a5e3405ec Cr-Commit-Position: refs/heads/master@{#327554}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/bluetooth/bluetooth_socket_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:55:27 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-04-29 19:01:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119513002/1
5 years, 7 months ago (2015-04-29 19:02:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:25:56 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:27:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75727f2f2a3196e77c3c14ee4647ed0a5e3405ec
Cr-Commit-Position: refs/heads/master@{#327554}

Powered by Google App Engine
This is Rietveld 408576698