Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11195058: Extensions Docs Server: Show parameters of functions that are properties of an object (Closed)

Created:
8 years, 2 months ago by cduvall
Modified:
8 years, 1 month ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, pam+watch_chromium.org, Mihai Parparita -not on Chrome, not at google - send to devlin
Visibility:
Public.

Description

Extensions Docs Server: Show parameters of functions that are properties of an object The docs server was not showing the parameters of a function that was a property of an object. This is now fixed. BUG=156673 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164224

Patch Set 1 #

Total comments: 4

Patch Set 2 : add return types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 1 2 chunks +7 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json View 1 7 chunks +24 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/css/site.css View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/parameter_full.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/model.py View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cduvall
8 years, 2 months ago (2012-10-19 00:45:11 UTC) #1
Aaron Boodman
http://codereview.chromium.org/11195058/diff/1/chrome/common/extensions/docs/server2/api_data_source.py File chrome/common/extensions/docs/server2/api_data_source.py (right): http://codereview.chromium.org/11195058/diff/1/chrome/common/extensions/docs/server2/api_data_source.py#newcode20 chrome/common/extensions/docs/server2/api_data_source.py:20: _VERSION = 1 Note that this conflicts with: http://codereview.chromium.org/11195055/ ...
8 years, 1 month ago (2012-10-24 22:29:24 UTC) #2
cduvall
http://codereview.chromium.org/11195058/diff/1/chrome/common/extensions/docs/server2/api_data_source.py File chrome/common/extensions/docs/server2/api_data_source.py (right): http://codereview.chromium.org/11195058/diff/1/chrome/common/extensions/docs/server2/api_data_source.py#newcode20 chrome/common/extensions/docs/server2/api_data_source.py:20: _VERSION = 1 On 2012/10/24 22:29:24, Aaron Boodman wrote: ...
8 years, 1 month ago (2012-10-25 23:42:02 UTC) #3
Aaron Boodman
8 years, 1 month ago (2012-10-26 00:10:08 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698