Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 11195039: Add "contains" method to Collection. (Closed)

Created:
8 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 2 months ago
Reviewers:
ahe, floitsch
CC:
reviews_dartlang.org, Anton Muhin, kasperl, bakster
Visibility:
Public.

Description

Add "contains" method to Collection. This versions does not implement "contains" on DOM lists. Committed: https://code.google.com/p/dart/source/detail?r=13806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -70 lines) Patch
M lib/compiler/implementation/lib/interceptors.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M lib/core/collection.dart View 2 chunks +60 lines, -29 lines 0 comments Download
M lib/core/core.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/core/corelib_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M lib/core/list.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A lib/core/sequences.dart View 1 chunk +204 lines, -0 lines 0 comments Download
M lib/core/string.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/collections.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/lib/array.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/lib/byte_array.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/growable_array.dart View 2 chunks +4 lines, -26 lines 0 comments Download
A tests/corelib/collection_contains_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M tests/corelib/collection_to_string_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
Reapplying without changes to html-lib templates. The HTML lists won't implement contains yet. CC'ing people ...
8 years, 2 months ago (2012-10-18 11:25:38 UTC) #1
floitsch
LGTM.
8 years, 2 months ago (2012-10-18 11:48:09 UTC) #2
sra1
On 2012/10/18 11:25:38, Lasse Reichstein Nielsen wrote: > Reapplying without changes to html-lib templates. The ...
8 years, 2 months ago (2012-10-19 02:26:29 UTC) #3
ahe
8 years, 2 months ago (2012-10-19 07:58:23 UTC) #4
What happened to dart:core being a library of few essential concepts?

Why do we need seven different classes to represent the concept which is
essentially a "list"?

Why does every user of Dart need to know the difference between "List",
"Iterator", "Collection", "Sequence", "SequenceCollection", "SequenceList", and
"SequenceIterator"?

Are you aware that each class you define in dart:core is by default imported
into all libraries?

Could you explain why a "sequence" implies unmodifiable? Could you explain why
we don't need a four more classes to model lists that can only be written to?

Powered by Google App Engine
This is Rietveld 408576698