Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1119503002: Add scottmg to crash component owners (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scottmg to crash component owners (And mark to gypi owners) TBR=mark@chromium.org Committed: https://crrev.com/36eb65367951a41d28cb0de73cfed44dfa8179ff Cr-Commit-Position: refs/heads/master@{#327528}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add mark to gypi owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/crash/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
scottmg
5 years, 7 months ago (2015-04-29 18:00:46 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/1119503002/diff/1/components/OWNERS File components/OWNERS (right): https://codereview.chromium.org/1119503002/diff/1/components/OWNERS#newcode47 components/OWNERS:47: per-file crash.gypi=scottmg@chromium.org I guess I should add myself ...
5 years, 7 months ago (2015-04-29 18:01:27 UTC) #2
scottmg
https://codereview.chromium.org/1119503002/diff/1/components/OWNERS File components/OWNERS (right): https://codereview.chromium.org/1119503002/diff/1/components/OWNERS#newcode47 components/OWNERS:47: per-file crash.gypi=scottmg@chromium.org On 2015/04/29 18:01:26, Mark Mentovai wrote: > ...
5 years, 7 months ago (2015-04-29 18:02:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119503002/20001
5 years, 7 months ago (2015-04-29 18:03:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59955)
5 years, 7 months ago (2015-04-29 18:11:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119503002/20001
5 years, 7 months ago (2015-04-29 18:26:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-29 18:31:30 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:32:32 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/36eb65367951a41d28cb0de73cfed44dfa8179ff
Cr-Commit-Position: refs/heads/master@{#327528}

Powered by Google App Engine
This is Rietveld 408576698