Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: runtime/bin/main.cc

Issue 11195017: Allow package: imports inside isolates (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addresses Siva's comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | tests/isolate/timer_isolate_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/main.cc
diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc
index d4fe179cc993b18d4c0ab76719da757dfc237207..df010169452e9282d51ca221ef79c3a8d50d56f3 100644
--- a/runtime/bin/main.cc
+++ b/runtime/bin/main.cc
@@ -399,7 +399,6 @@ static void DumpPprofSymbolInfo() {
// Returns true on success, false on failure.
static bool CreateIsolateAndSetupHelper(const char* script_uri,
const char* main,
- bool resolve_script,
void* data,
char** error) {
Dart_Isolate isolate =
@@ -466,7 +465,7 @@ static bool CreateIsolateAndSetupHelper(const char* script_uri,
result = DartUtils::PrepareForScriptLoading(package_root, builtin_lib);
CHECK_RESULT(result);
- library = DartUtils::LoadScript(script_uri, resolve_script, builtin_lib);
+ library = DartUtils::LoadScript(script_uri, builtin_lib);
}
CHECK_RESULT(library);
if (!Dart_IsLibrary(library)) {
@@ -489,7 +488,6 @@ static bool CreateIsolateAndSetup(const char* script_uri,
void* data, char** error) {
return CreateIsolateAndSetupHelper(script_uri,
main,
- false, // script_uri already canonical.
new IsolateData(),
error);
}
@@ -684,7 +682,6 @@ int main(int argc, char** argv) {
char* isolate_name = BuildIsolateName(script_name, "main");
if (!CreateIsolateAndSetupHelper(script_name,
"main",
- true, // Canonicalize the script name.
new IsolateData(),
&error)) {
fprintf(stderr, "%s\n", error);
« no previous file with comments | « runtime/bin/gen_snapshot.cc ('k') | tests/isolate/timer_isolate_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698