Issue 1119453003: [Importer] Allow Chrome to import bookmark files without a charset specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1119453003: [Importer] Allow Chrome to import bookmark files without a charset specified. (Closed)

Created:
5 years, 7 months ago by Ilya Sherman

Modified:
5 years, 7 months ago

Reviewers:
gab

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Importer] Allow Chrome to import bookmark files without a charset specified. Internet Explorer will, apparently, generate bookmark files without any charset specified. Fall back to utf-8 in that case, so that import can still succeed. BUG=460423 TEST=unit_tests R=gab@chromium.org Committed: https://crrev.com/0f6b38ae3f1f4784f35c1c197db4230bfacd67e6 Cr-Commit-Position: refs/heads/master@{#329930}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -1 line)			Patch
A	chrome/test/data/bookmark_html_reader/ie_sans_charset.html	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/utility/importer/bookmark_html_reader.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/utility/importer/bookmark_html_reader_unittest.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119453003/1

5 years, 7 months ago (2015-05-14 19:05:15 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 21:10:59 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0f6b38ae3f1f4784f35c1c197db4230bfacd67e6
Cr-Commit-Position: refs/heads/master@{#329930}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages