Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: ui/events/event_targeter.cc

Issue 1119423003: Refactors away method implementations in ui::EventTargeter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactors ui::EventTargeter (rebased) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event_targeter.h ('k') | ui/events/events.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event_targeter.cc
diff --git a/ui/events/event_targeter.cc b/ui/events/event_targeter.cc
deleted file mode 100644
index 5d43b29ba941114c7357ea8c930800d8272dff64..0000000000000000000000000000000000000000
--- a/ui/events/event_targeter.cc
+++ /dev/null
@@ -1,73 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "ui/events/event_targeter.h"
-
-#include "ui/events/event.h"
-#include "ui/events/event_target.h"
-#include "ui/events/event_target_iterator.h"
-
-namespace ui {
-
-EventTargeter::~EventTargeter() {
-}
-
-EventTarget* EventTargeter::FindTargetForEvent(EventTarget* root,
- Event* event) {
- if (event->IsMouseEvent() ||
- event->IsScrollEvent() ||
- event->IsTouchEvent() ||
- event->IsGestureEvent()) {
- return FindTargetForLocatedEvent(root,
- static_cast<LocatedEvent*>(event));
- }
- return root;
-}
-
-EventTarget* EventTargeter::FindTargetForLocatedEvent(EventTarget* root,
- LocatedEvent* event) {
- scoped_ptr<EventTargetIterator> iter = root->GetChildIterator();
- if (iter) {
- EventTarget* target = root;
- for (EventTarget* child = iter->GetNextTarget(); child;
- child = iter->GetNextTarget()) {
- EventTargeter* targeter = child->GetEventTargeter();
- if (!targeter)
- targeter = this;
- if (!targeter->SubtreeShouldBeExploredForEvent(child, *event))
- continue;
- target->ConvertEventToTarget(child, event);
- target = child;
- EventTarget* child_target =
- targeter->FindTargetForLocatedEvent(child, event);
- if (child_target)
- return child_target;
- }
- target->ConvertEventToTarget(root, event);
- }
- return root->CanAcceptEvent(*event) ? root : NULL;
-}
-
-bool EventTargeter::SubtreeShouldBeExploredForEvent(EventTarget* target,
- const LocatedEvent& event) {
- return SubtreeCanAcceptEvent(target, event) &&
- EventLocationInsideBounds(target, event);
-}
-
-EventTarget* EventTargeter::FindNextBestTarget(EventTarget* previous_target,
- Event* event) {
- return NULL;
-}
-
-bool EventTargeter::SubtreeCanAcceptEvent(EventTarget* target,
- const LocatedEvent& event) const {
- return true;
-}
-
-bool EventTargeter::EventLocationInsideBounds(EventTarget* target,
- const LocatedEvent& event) const {
- return true;
-}
-
-} // namespace ui
« no previous file with comments | « ui/events/event_targeter.h ('k') | ui/events/events.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698