Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Side by Side Diff: ui/views/view_targeter.cc

Issue 1119423003: Refactors away method implementations in ui::EventTargeter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactors away method implementations in ui::EventTargeter Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« ui/events/event_targeter.cc ('K') | « ui/views/view_targeter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/view_targeter.h" 5 #include "ui/views/view_targeter.h"
6 6
7 #include "ui/events/event_target.h" 7 #include "ui/events/event_target.h"
8 #include "ui/views/focus/focus_manager.h" 8 #include "ui/views/focus/focus_manager.h"
9 #include "ui/views/view.h" 9 #include "ui/views/view.h"
10 #include "ui/views/view_targeter_delegate.h" 10 #include "ui/views/view_targeter_delegate.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 ui::GestureEvent* gesture = event->AsGestureEvent(); 60 ui::GestureEvent* gesture = event->AsGestureEvent();
61 ui::EventTarget* next_target = 61 ui::EventTarget* next_target =
62 FindNextBestTargetForGestureEvent(previous_target, *gesture); 62 FindNextBestTargetForGestureEvent(previous_target, *gesture);
63 previous_target->ConvertEventToTarget(next_target, gesture); 63 previous_target->ConvertEventToTarget(next_target, gesture);
64 return next_target; 64 return next_target;
65 } 65 }
66 66
67 return previous_target->GetParentTarget(); 67 return previous_target->GetParentTarget();
68 } 68 }
69 69
70 bool ViewTargeter::SubtreeCanAcceptEvent(
71 ui::EventTarget* target,
72 const ui::LocatedEvent& event) const {
73 NOTREACHED();
74 return false;
75 }
76
77 bool ViewTargeter::EventLocationInsideBounds(
78 ui::EventTarget* target,
79 const ui::LocatedEvent& event) const {
80 NOTREACHED();
81 return false;
82 }
83
84 View* ViewTargeter::FindTargetForKeyEvent(View* root, const ui::KeyEvent& key) { 70 View* ViewTargeter::FindTargetForKeyEvent(View* root, const ui::KeyEvent& key) {
85 if (root->GetFocusManager()) 71 if (root->GetFocusManager())
86 return root->GetFocusManager()->GetFocusedView(); 72 return root->GetFocusManager()->GetFocusedView();
87 return NULL; 73 return NULL;
88 } 74 }
89 75
90 View* ViewTargeter::FindTargetForScrollEvent(View* root, 76 View* ViewTargeter::FindTargetForScrollEvent(View* root,
91 const ui::ScrollEvent& scroll) { 77 const ui::ScrollEvent& scroll) {
92 gfx::Rect rect(scroll.location(), gfx::Size(1, 1)); 78 gfx::Rect rect(scroll.location(), gfx::Size(1, 1));
93 return root->GetEffectiveViewTargeter()->TargetForRect(root, rect); 79 return root->GetEffectiveViewTargeter()->TargetForRect(root, rect);
(...skipping 11 matching lines...) Expand all
105 } 91 }
106 92
107 ui::EventTarget* ViewTargeter::FindNextBestTargetForGestureEvent( 93 ui::EventTarget* ViewTargeter::FindNextBestTargetForGestureEvent(
108 ui::EventTarget* previous_target, 94 ui::EventTarget* previous_target,
109 const ui::GestureEvent& gesture) { 95 const ui::GestureEvent& gesture) {
110 NOTREACHED(); 96 NOTREACHED();
111 return NULL; 97 return NULL;
112 } 98 }
113 99
114 } // namespace views 100 } // namespace views
OLDNEW
« ui/events/event_targeter.cc ('K') | « ui/views/view_targeter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698