Issue 11194047: Simplify onclick action code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11194047: Simplify onclick action code. (Closed)

Created:
8 years, 2 months ago by kochi

Modified:
8 years, 2 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Simplify onclick action code. This is based on the review comment in http://codereview.chromium.org/11178004/ BUG=none TEST=see issue 150740. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162954

Patch Set 2 : Remove curly braces. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	chrome/browser/resources/options/browser_options.js	View	1	1 chunk	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm with nit http://codereview.chromium.org/11194047/diff/1/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (right): http://codereview.chromium.org/11194047/diff/1/chrome/browser/resources/options/browser_options.js#newcode649 chrome/browser/resources/options/browser_options.js:649: } else { no curlies

8 years, 2 months ago (2012-10-18 23:35:41 UTC) #2

kochi

Thanks for the review! http://codereview.chromium.org/11194047/diff/1/chrome/browser/resources/options/browser_options.js File chrome/browser/resources/options/browser_options.js (right): http://codereview.chromium.org/11194047/diff/1/chrome/browser/resources/options/browser_options.js#newcode649 chrome/browser/resources/options/browser_options.js:649: } else { On 2012/10/18 ...

8 years, 2 months ago (2012-10-19 01:10:27 UTC) #3

commit-bot: I haz the power

8 years, 2 months ago (2012-10-19 01:45:30 UTC) #4

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/11194047/5001

Expand Messages | Collapse Messages

Issue 11194047: Simplify onclick action code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove curly braces. #

Messages