src/trusted/validator_arm/validator_huge_tests.cc - Issue 11194045: Change BKPT and UDF encodings on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_arm/validator_huge_tests.cc

Issue 11194045: Change BKPT and UDF encodings on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Factor out special BKPT/UDF encodings in a separate header file instead of repeating them in a few … Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/validator_arm/validator_huge_tests.cc

diff --git a/src/trusted/validator_arm/validator_huge_tests.cc b/src/trusted/validator_arm/validator_huge_tests.cc

index a6ff9d6c36fa541c71c0182d951979bfdfd7a3a6..78427c48ce2bd22a87eab1042f41dfe785d85553 100644

--- a/src/trusted/validator_arm/validator_huge_tests.cc

+++ b/src/trusted/validator_arm/validator_huge_tests.cc

@@ -106,8 +106,7 @@ TEST_F(ValidatorTests, WholeA32InstructionSpaceTesting) {

uint32_t expected_branch_target_register = expect_bx_or_blx ?

(i & 0xF) : // When present, always Rm(3:0).

nacl_arm_dec::Register::kNone;

- bool expect_literal_pool_head =

- (i == nacl_arm_dec::kLiteralPoolHeadInstruction);

+ bool expect_literal_pool_head =(i == nacl_arm_dec::kLiteralPoolHead);

bool expect_load_store_or_unsafe = expect_unconditional ?

// Advanced SIMD element or structure load/store instructions.

// 1111 0100 xx0x xxxx xxxx xxxx xxxx xxxx