Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: src/trusted/validator_arm/actual_classes.h

Issue 11194045: Change BKPT and UDF encodings on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Update copyright. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/actual_classes.h
diff --git a/src/trusted/validator_arm/actual_classes.h b/src/trusted/validator_arm/actual_classes.h
index f2e202d1e51354ec7b66ac8cd5b02f7ca78d1946..2cfb107d9ad0fc73cfa87ef410e997dd42ab313d 100644
--- a/src/trusted/validator_arm/actual_classes.h
+++ b/src/trusted/validator_arm/actual_classes.h
@@ -718,27 +718,27 @@ class EffectiveNoOp : public OldClassDecoder {
NACL_DISALLOW_COPY_AND_ASSIGN(EffectiveNoOp);
};
-// Models all instructions that reliably trap, preventing execution from falling
-// through to the next instruction. Note that roadblocks currently have no
-// special role in the SFI model, so Breakpoints are distinguished below.
-class Roadblock : public OldClassDecoder {
+// UDF
+// Permanently undefined in the ARM ISA.
+class PermanentlyUndefined : public OldClassDecoder {
public:
- Roadblock() {}
+ PermanentlyUndefined() {}
virtual SafetyLevel safety(Instruction i) const;
virtual RegisterList defs(Instruction i) const;
private:
- NACL_DISALLOW_COPY_AND_ASSIGN(Roadblock);
+ NACL_DISALLOW_COPY_AND_ASSIGN(PermanentlyUndefined);
};
// BKPT
// We model this mostly so we can use it to recognize literal pools -- untrusted
// code isn't expected to use it, but it's not unsafe, and there are cases where
// we may generate it.
-class Breakpoint : public Roadblock {
+class Breakpoint : public OldClassDecoder {
public:
Breakpoint() {}
virtual SafetyLevel safety(Instruction i) const;
+ virtual RegisterList defs(Instruction i) const;
virtual bool is_literal_pool_head(Instruction i) const;
private:
« no previous file with comments | « src/trusted/service_runtime/testdata/arm/unaligned_data_irt.nexe ('k') | src/trusted/validator_arm/actual_classes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698