src/trusted/debug_stub/abi.cc - Issue 11194045: Change BKPT and UDF encodings on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/debug_stub/abi.cc

Issue 11194045: Change BKPT and UDF encodings on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fixes proposed by mseaborn. I'll submit try jobs with them, and factor things out with #define tomo… Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/debug_stub/abi.cc

diff --git a/src/trusted/debug_stub/abi.cc b/src/trusted/debug_stub/abi.cc

index b12d89e862ae0ff1dbe702bde81f47ed0af69977..558c3bfe9da03567fddc95414f9c7f8596a2696f 100644

--- a/src/trusted/debug_stub/abi.cc

+++ b/src/trusted/debug_stub/abi.cc

@@ -129,7 +129,8 @@ static Abi::BPDef breakpoint_x86 = {

breakpoint_code_x86

};

-static uint32_t breakpoint_code_arm[] = { 0xe1277777 /* bkpt 0x7777 */ };

+// Breakpoint on ARM is defined in the validator's model.h.

+static uint32_t breakpoint_code_arm[] = { 0xE125BE7F /* BKPT 0x5BEF */ };

static Abi::BPDef breakpoint_arm = {

sizeof(breakpoint_code_arm),

(uint8_t *) breakpoint_code_arm