src/trusted/validator_arm/gen/arm32_decode_named.cc - Issue 11194045: Change BKPT and UDF encodings on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_arm/gen/arm32_decode_named.cc

Issue 11194045: Change BKPT and UDF encodings on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Clarify comments. Fix unaligned_data_irt.nexe, it had a hard-coded BKPT #0x7777. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/validator_arm/gen/arm32_decode_named.cc

diff --git a/src/trusted/validator_arm/gen/arm32_decode_named.cc b/src/trusted/validator_arm/gen/arm32_decode_named.cc

index 93f7e0798c8492d10b8f41de99d0ebc8b1223c36..cfb2bc614c89e97ba2975c3b749c53a1bfbe9a1f 100644

--- a/src/trusted/validator_arm/gen/arm32_decode_named.cc

+++ b/src/trusted/validator_arm/gen/arm32_decode_named.cc

@@ -1153,7 +1153,7 @@ const NamedClassDecoder& NamedArm32DecoderState::decode_media_instructions(

if ((inst.Bits() & 0x01F00000) == 0x01F00000 /* op1(24:20)=11111 */ &&

(inst.Bits() & 0x000000E0) == 0x000000E0 /* op2(7:5)=111 */) {

- return Roadblock_Udf_Rule_A1_instance_;

+ return PermanentlyUndefined_Udf_Rule_A1_instance_;

}

if ((inst.Bits() & 0x01E00000) == 0x01A00000 /* op1(24:20)=1101x */ &&