Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/trusted/debug_stub/abi.cc

Issue 11194045: Change BKPT and UDF encodings on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/trusted/service_runtime/arch/arm/nacl_text_pad_test.S » ('j') | src/trusted/service_runtime/arch/arm/nacl_text_pad_test.S » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/debug_stub/abi.cc
diff --git a/src/trusted/debug_stub/abi.cc b/src/trusted/debug_stub/abi.cc
index b12d89e862ae0ff1dbe702bde81f47ed0af69977..558c3bfe9da03567fddc95414f9c7f8596a2696f 100644
--- a/src/trusted/debug_stub/abi.cc
+++ b/src/trusted/debug_stub/abi.cc
@@ -129,7 +129,8 @@ static Abi::BPDef breakpoint_x86 = {
breakpoint_code_x86
};
-static uint32_t breakpoint_code_arm[] = { 0xe1277777 /* bkpt 0x7777 */ };
+// Breakpoint on ARM is defined in the validator's model.h.
+static uint32_t breakpoint_code_arm[] = { 0xE125BE7F /* BKPT 0x5BEF */ };
Mark Seaborn 2012/10/18 01:21:39 Can this reuse NACL_HALT_OPCODE?
static Abi::BPDef breakpoint_arm = {
sizeof(breakpoint_code_arm),
(uint8_t *) breakpoint_code_arm
« no previous file with comments | « no previous file | src/trusted/service_runtime/arch/arm/nacl_text_pad_test.S » ('j') | src/trusted/service_runtime/arch/arm/nacl_text_pad_test.S » ('J')

Powered by Google App Engine
This is Rietveld 408576698