Change BKPT and UDF encodings on ARM.

src/trusted/debug_stub/abi.cc

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <assert.h>
 
 #include <map>
 #include <string>
@@ skipping 111 matching lines @@
 //     a fault.  INT3 leaves %eip/%rip pointing to the address after
 //     the INT3 instruction, which makes it harder to tell
 //     unambiguously whether a fault was produced by an INT3 or the
 //     instruction after it.
 static uint8_t breakpoint_code_x86[] = { 0xf4 /* HLT */ };
 static Abi::BPDef breakpoint_x86 = {
   sizeof(breakpoint_code_x86),
   breakpoint_code_x86
 };
 
-static uint32_t breakpoint_code_arm[] = { 0xe1277777 /* bkpt 0x7777 */ };
+// Breakpoint on ARM is defined in the validator's model.h.
+static uint32_t breakpoint_code_arm[] = { 0xE125BE7F /* BKPT 0x5BEF */ };

[Mark Seaborn, 2012/10/18 01:21:39]

Can this reuse NACL_HALT_OPCODE?

 static Abi::BPDef breakpoint_arm = {
   sizeof(breakpoint_code_arm),
   (uint8_t *) breakpoint_code_arm
 };
 
 static AbiMap_t *GetAbis() {
   static AbiMap_t *_abis = new AbiMap_t();
   return _abis;
 }
 
@@ skipping 107 matching lines @@
   if (index >= regCnt_) return NULL;
 
   return &regDefs_[index];
 }
 
 const Abi::RegDef *Abi::GetInstPtrDef() const {
   return GetRegisterDef(ipIndex_);
 }
 
 }  // namespace gdb_rsp