Issue 11194027: Revert 162293 - Enable DEP earlier on Vista and below

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11194027: Revert 162293 - Enable DEP earlier on Vista and below (Closed)

Created:
8 years, 2 months ago by mattm

Modified:
8 years, 2 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 162293 - Enable DEP earlier on Vista and below We can't enable DEP at launch prior to Win7, but we can queue an APC to enable immediately after the loader finishes. BUG=147752 Review URL: https://chromiumcodereview.appspot.com/10944015 TBR=jschuh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162300

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -29 lines)			Patch
M	sandbox/win/src/process_mitigations.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	sandbox/win/src/process_mitigations.cc	View	5 chunks	+24 lines, -24 lines	0 comments	Download
M	sandbox/win/src/sandbox_policy_base.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mattm

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/29469/steps/sbox_integration_tests/logs/stdio [ RUN ] ProcessMitigationsTest.CheckDep win\src\process_mitigations_test.cc(203): error: Value of: runner.RunTest(L"CheckDep") Actual: -1073741819 Expected: SBOX_TEST_SUCCEEDED Which ...

8 years, 2 months ago (2012-10-17 02:01:23 UTC) #2

mattm

8 years, 2 months ago (2012-10-17 02:44:54 UTC) #3

Also caused timeouts of all tests in content_browsertests, browser_tests,
interactive_ui_tests, nacl_integration.

ex:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20...
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%282%29/bui...
http://build.chromium.org/p/chromium.win/builders/NACL%20Tests/builds/34738/s...
http://build.chromium.org/p/chromium.win/builders/Win%20Aura/builds/23604/ste...

Expand Messages | Collapse Messages