utils/pub/git.dart - Issue 11194025: Second round of cleanups for new optional parameter semantics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/git.dart

Issue 11194025: Second round of cleanups for new optional parameter semantics. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/pub/git.dart

===================================================================

--- utils/pub/git.dart (revision 13712)

+++ utils/pub/git.dart (working copy)

@@ -23,7 +23,7 @@

/// Run a git process with [args] from [workingDir]. Returns the stdout as a

/// list of strings if it succeeded. Completes to an exception if it failed.

-Future<List<String>> run(List<String> args, [String workingDir]) {

+Future<List<String>> run(List<String> args, {String workingDir}) {

return _gitCommand.chain((git) {

return runProcess(git, args, workingDir: workingDir);

}).transform((result) {

« tests/compiler/dart2js/redundant_phi_eliminator_test.dart ('K') | « tests/standalone/io/web_socket_test.dart ('k') | utils/pub/git_source.dart » ('j') | utils/pub/io.dart » ('J')