Second round of cleanups for new optional parameter semantics.

tests/compiler/dart2js/resolver_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #import('dart:uri');
 
 #import("../../../lib/compiler/implementation/leg.dart");
 #import("../../../lib/compiler/implementation/elements/elements.dart");
 #import("../../../lib/compiler/implementation/tree/tree.dart");
 #import("../../../lib/compiler/implementation/scanner/scannerlib.dart");
@@ skipping 537 matching lines @@
 
   VariableDefinitions bNode = bElement.variables.parseNode(compiler);
   VariableDefinitions cNode = cElement.variables.parseNode(compiler);
   Expect.equals(bNode, cNode);
   Expect.isNull(bNode.type);
   Expect.isTrue(bNode.modifiers.isVar());
 }
 
 resolveConstructor(String script, String statement, String className,
                    String constructor, int expectedElementCount,
-                   [List expectedWarnings = const [],
-                    List expectedErrors = const [],
-                    String corelib = DEFAULT_CORELIB]) {
-  MockCompiler compiler = new MockCompiler(corelib);
+                   {List expectedWarnings: const [],
+                    List expectedErrors: const [],
+                    String corelib: DEFAULT_CORELIB}) {
+  MockCompiler compiler = new MockCompiler(coreSource: corelib);
   compiler.parseScript(script);
   compiler.resolveStatement(statement);
   ClassElement classElement =
       compiler.mainApp.find(buildSourceString(className));
   Element element =
       classElement.lookupConstructor(
           new Selector.callConstructor(buildSourceString(constructor),
                                        classElement.getLibrary()));
   FunctionExpression tree = element.parseNode(compiler);
   ResolverVisitor visitor = new ResolverVisitor(compiler, element);
@@ skipping 51 matching lines @@
                 int foo; int bar;
                 A() : this.foo = 1, bar = 2;
               }""";
   resolveConstructor(script, "A a = new A();", "A", "A", 2);
 
   script = """class A {
                 int foo; A a;
                 A() : a.foo = 1;
                 }""";
   resolveConstructor(script, "A a = new A();", "A", "A", 0,
-                     [], [MessageKind.INVALID_RECEIVER_IN_INITIALIZER]);
+                     expectedWarnings: [],
+                     expectedErrors:
+                         [MessageKind.INVALID_RECEIVER_IN_INITIALIZER]);
 
   script = """class A {
                 int foo;
                 A() : this.foo = 1, this.foo = 2;
               }""";
   resolveConstructor(script, "A a = new A();", "A", "A", 2,
-                     [MessageKind.ALREADY_INITIALIZED],
-                     [MessageKind.DUPLICATE_INITIALIZER]);
+                     expectedWarnings: [MessageKind.ALREADY_INITIALIZED],
+                     expectedErrors: [MessageKind.DUPLICATE_INITIALIZER]);
 
   script = """class A {
                 A() : this.foo = 1;
               }""";
   resolveConstructor(script, "A a = new A();", "A", "A", 0,
-                     [], [MessageKind.CANNOT_RESOLVE]);
+                     expectedWarnings: [],
+                     expectedErrors: [MessageKind.CANNOT_RESOLVE]);
 
   script = """class A {
                 int foo;
                 int bar;
                 A() : this.foo = bar;
               }""";
   resolveConstructor(script, "A a = new A();", "A", "A", 3,
-                     [], [MessageKind.NO_INSTANCE_AVAILABLE]);
+                     expectedWarnings: [],
+                     expectedErrors: [MessageKind.NO_INSTANCE_AVAILABLE]);
 
   script = """class A {
                 int foo() => 42;
                 A() : foo();
               }""";
   resolveConstructor(script, "A a = new A();", "A", "A", 0,
-                     [], [MessageKind.CONSTRUCTOR_CALL_EXPECTED]);
+                     expectedWarnings: [],
+                     expectedErrors: [MessageKind.CONSTRUCTOR_CALL_EXPECTED]);
 
   script = """class A {
                 int i;
                 A.a() : this.b(0);
                 A.b(int i);
               }""";
-  resolveConstructor(script, "A a = new A.a();", "A", "a", 1,
-                     [], []);
+  resolveConstructor(script, "A a = new A.a();", "A", "a", 1);
 
   script = """class A {
                 int i;
                 A.a() : i = 42, this(0);
                 A(int i);
               }""";
   resolveConstructor(script, "A a = new A.a();", "A", "a", 2,
-                     [], [MessageKind.REDIRECTING_CONSTRUCTOR_HAS_INITIALIZER]);
+                     expectedWarnings: [],
+                     expectedErrors:
+                         [MessageKind.REDIRECTING_CONSTRUCTOR_HAS_INITIALIZER]);
 
   script = """class A {
                 int i;
                 A(i);
               }
               class B extends A {
                 B() : super(0);
               }""";
-  resolveConstructor(script, "B a = new B();", "B", "B", 1,
-                     [], []);
+  resolveConstructor(script, "B a = new B();", "B", "B", 1);
 
   script = """class A {
                 int i;
                 A(i);
               }
               class B extends A {
                 B() : super(0), super(1);
               }""";
   resolveConstructor(script, "B b = new B();", "B", "B", 2,
-                     [], [MessageKind.DUPLICATE_SUPER_INITIALIZER]);
+                     expectedWarnings: [],
+                     expectedErrors: [MessageKind.DUPLICATE_SUPER_INITIALIZER]);
 
   script = "";
   final String CORELIB_WITH_INVALID_OBJECT =
       '''print(var obj) {}
          class int {}
          class double {}
          class bool {}
          class String {}
          class num {}
          class Function {}
          class List {}
          class Closure {}
          class Null {}
          class Dynamic_ {}
          class Object { Object() : super(); }''';
   resolveConstructor(script, "Object o = new Object();", "Object", "Object", 1,
-                     [], [MessageKind.SUPER_INITIALIZER_IN_OBJECT],
+                     expectedWarnings: [],
+                     expectedErrors: [MessageKind.SUPER_INITIALIZER_IN_OBJECT],
                      corelib: CORELIB_WITH_INVALID_OBJECT);
 }
 
 map(ResolverVisitor visitor) {
   TreeElementMapping elements = visitor.mapping;
   return elements.map;
 }
 
 at(Link link, int index) => (index == 0) ? link.head : at(link.tail, index - 1);
 
@@ skipping 59 matching lines @@
         var d = new D();
         --d;
       }""";
   final compiler = compileScript(script);
 
   checkMemberResolved(compiler, 'A', operatorName('+', false));
   checkMemberResolved(compiler, 'B', operatorName('+', false));
   checkMemberResolved(compiler, 'C', operatorName('-', false));
   checkMemberResolved(compiler, 'D', operatorName('-', false));
 }