Second round of cleanups for new optional parameter semantics.

pkg/unittest/mock.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The error formatter for mocking is a bit different from the default one
  * for unit testing; instead of the third argument being a 'reason'
  * it is instead a [signature] describing the method signature filter
  * that was used to select the logs that were verified.
  */
@@ skipping 811 matching lines @@
    * to see what parameters were passed in, in which case we would set
    * [includeKeys].
    *
    * As another simple example, say we wanted to know the three method
    * calls that immediately preceded each failing call to commit():
    *
    *     print(log.preceding(log.getLogs(callsTo('commit'), returning(-1)),
    *         distance: 3).toString());
    */
   LogEntryList preceding(LogEntryList keys,
-                         [mockNameFilter = null,
-                         logFilter = null,
-                         int distance = 1,
-                         bool includeKeys = false]) =>
+                         {mockNameFilter: null,
+                         logFilter: null,
+                         int distance: 1,
+                         bool includeKeys: false}) =>
       _neighboring(true, keys, mockNameFilter, logFilter,
           distance, includeKeys);
 
   /**
    * Iterate through the LogEntryList looking for matches to the entries
    * in [keys]; for each match found the closest [distance] subsequent log
    * entries that match [mocknameFilter] and [logFilter] will be included in
    * the result. If [includeKeys] is true then the entries in [keys] that
    * resulted in entries in the output list are themselves included in the
    * output list. If [distance] is zero then all matches are included.
    * See [preceding] for a usage example.
    */
   LogEntryList following(LogEntryList keys,
-                         [mockNameFilter = null,
-                         logFilter = null,
-                         int distance = 1,
-                         bool includeKeys = false]) =>
+                         {mockNameFilter: null,
+                         logFilter: null,
+                         int distance: 1,
+                         bool includeKeys: false}) =>
       _neighboring(false, keys, mockNameFilter, logFilter,
           distance, includeKeys);
 }
 
 /**
  * [_TimesMatcher]s are used to make assertions about the number of
  * times a method was called.
  */
 class _TimesMatcher extends BaseMatcher {
   final int min, max;
@@ skipping 366 matching lines @@
   }
 
   /**
    * This constructor makes a mock that has a [name] and possibly uses
    * a shared [log]. If [throwIfNoBehavior] is true, any calls to methods
    * that have no defined behaviors will throw an exception; otherwise they
    * will be allowed and logged (but will not do anything).
    * If [enableLogging] is false, no logging will be done initially (whether
    * or not a [log] is supplied), but [logging] can be set to true later.
    */
-  Mock.custom([this.name,
+  Mock.custom({this.name,
                this.log,
-               throwIfNoBehavior = false,
-               enableLogging = true]) : _throwIfNoBehavior = throwIfNoBehavior {
+               throwIfNoBehavior: false,
+               enableLogging: true}) : _throwIfNoBehavior = throwIfNoBehavior {
     if (log != null && name == null) {
       throw new Exception("Mocks with shared logs must have a name.");
     }
     logging = enableLogging;
     _behaviors = new Map<String,Behavior>();
   }
 
   /**
    * [when] is used to create a new or extend an existing [Behavior].
    * A [CallMatcher] [filter] must be supplied, and the [Behavior]s for
@@ skipping 197 matching lines @@
       }
     }
   }
 
   /** Clear both logs and behavior. */
   void reset() {
     resetBehavior();
     clearLogs();
   }
 }