Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 11194025: Second round of cleanups for new optional parameter semantics. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class LocalPlaceholder { 5 class LocalPlaceholder {
6 final String identifier; 6 final String identifier;
7 final Set<Node> nodes; 7 final Set<Node> nodes;
8 LocalPlaceholder(this.identifier) : nodes = new Set<Node>(); 8 LocalPlaceholder(this.identifier) : nodes = new Set<Node>();
9 int hashCode() => identifier.hashCode(); 9 int hashCode() => identifier.hashCode();
10 String toString() => 10 String toString() =>
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 collector.makeElementPlaceholder(node.selector, element); 126 collector.makeElementPlaceholder(node.selector, element);
127 // Another ugly case: <lib prefix>.<top level> is represented as 127 // Another ugly case: <lib prefix>.<top level> is represented as
128 // receiver: lib prefix, selector: top level. 128 // receiver: lib prefix, selector: top level.
129 if (element.isTopLevel() && node.receiver != null) { 129 if (element.isTopLevel() && node.receiver != null) {
130 assert(elements[node.receiver].isPrefix()); 130 assert(elements[node.receiver].isPrefix());
131 // Hack: putting null into map overrides receiver of original node. 131 // Hack: putting null into map overrides receiver of original node.
132 collector.makeNullPlaceholder(node.receiver); 132 collector.makeNullPlaceholder(node.receiver);
133 } 133 }
134 } 134 }
135 135
136 internalError(String reason, [Node node]) { 136 internalError(String reason, {Node node}) {
137 collector.internalError(reason, node); 137 collector.internalError(reason, node);
138 } 138 }
139 } 139 }
140 140
141 class PlaceholderCollector extends Visitor { 141 class PlaceholderCollector extends Visitor {
142 final Compiler compiler; 142 final Compiler compiler;
143 final Set<String> fixedMemberNames; // member names which cannot be renamed. 143 final Set<String> fixedMemberNames; // member names which cannot be renamed.
144 final Map<Element, ElementAst> elementAsts; 144 final Map<Element, ElementAst> elementAsts;
145 final Set<Node> nullNodes; // Nodes that should not be in output. 145 final Set<Node> nullNodes; // Nodes that should not be in output.
146 final Set<Identifier> unresolvedNodes; 146 final Set<Identifier> unresolvedNodes;
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 636
637 visitBlock(Block node) { 637 visitBlock(Block node) {
638 for (Node statement in node.statements.nodes) { 638 for (Node statement in node.statements.nodes) {
639 if (statement is VariableDefinitions) { 639 if (statement is VariableDefinitions) {
640 makeVarDeclarationTypePlaceholder(statement); 640 makeVarDeclarationTypePlaceholder(statement);
641 } 641 }
642 } 642 }
643 node.visitChildren(this); 643 node.visitChildren(this);
644 } 644 }
645 } 645 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698