Second round of cleanups for new optional parameter semantics.

pkg/unittest/test/unittest_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(gram):
 // Unfortunately I can't seem to test anything that involves timeouts, e.g.
 // insufficient callbacks, because the timeout is controlled externally
 // (test.dart?), and we would need to use a shorter timeout for the inner tests
 // so the outer timeout doesn't fire. So I removed all such tests.
 // I'd like to revisit this at some point.
@@ skipping 13 matching lines @@
   final port = new ReceivePort();
   port.receive((msg, reply) {
     fn();
     port.close();
   });
   port.toSendPort().send(null, null);
 }
 
 String buildStatusString(int passed, int failed, int errors,
                          var results,
-                         [int count = 0,
-                         String setup = '', String teardown = '',
-                         String uncaughtError = null,
-                         String message = '']) {
+                         {int count: 0,
+                         String setup: '', String teardown: '',
+                         String uncaughtError: null,
+                         String message: ''}) {

[Bob Nystrom, 2012/10/17 16:21:38]

Check with Gram, but instead of making these named, how about making them
optional positional parameters and moving message to be the first one?

[regis, 2012/10/17 19:58:16]

Only 3 out of 14 calls pass a message, so I am not sure this is the right thing
to do. In any case, feel free to change it later the way you want. I am more
concerned about correctness than style in this cl.

   var totalTests = 0;
   String testDetails = '';
   if (results is String) {
     totalTests = passed + failed + errors;
     testDetails = ':$results:$message';
   } else {
     totalTests = results.length;
     for (var i = 0; i < results.length; i++) {
       testDetails = '$testDetails:${results[i].description}:'
           '${collapseWhitespace(results[i].message)}';
@@ skipping 11 matching lines @@
   String setup = ''; // the name of the test group setup function, if any
   String teardown = ''; // the name of the test group teardown function, if any
 
   // The port to communicate with the parent isolate
   SendPort _port;
 
   TestConfiguration(this._port);
 
   void onDone(int passed, int failed, int errors, List<TestCase> results,
       String uncaughtError) {
-    var result = buildStatusString(passed, failed, errors, results, count,
-        setup, teardown, uncaughtError);
+    var result = buildStatusString(passed, failed, errors, results,
+        count: count, setup: setup, teardown: teardown,
+        uncaughtError: uncaughtError);
     _port.send(result);
   }
 }
 runTest() {
   port.receive((testName, sendport) {
     configure(_testconfig = new TestConfiguration(sendport));
     if (testName == 'single correct test') {
       test(testName, () => expect(2 + 3, equals(5)));
     } else if (testName == 'single failing test') {
       test(testName, () => expect(2 + 2, equals(5)));
@@ skipping 102 matching lines @@
     'late exception test',
     'middle exception test'
   ];
 
   expected = [
     buildStatusString(1, 0, 0, tests[0]),
     buildStatusString(0, 1, 0, tests[1],
         message: 'Expected: <5> but: was <4>.'),
     buildStatusString(0, 1, 0, tests[2], message: 'Caught Exception: Fail.'),
     buildStatusString(2, 0, 0, 'a a::a b b'),
-    buildStatusString(1, 0, 0, 'a ${tests[4]}', 0, 'setup'),
-    buildStatusString(1, 0, 0, 'a ${tests[5]}', 0, '', 'teardown'),
-    buildStatusString(1, 0, 0, 'a ${tests[6]}', 0,
-        'setup', 'teardown'),
-    buildStatusString(1, 0, 0, tests[7], 1),
-    buildStatusString(0, 0, 1, tests[8], 1,
+    buildStatusString(1, 0, 0, 'a ${tests[4]}', count: 0, setup: 'setup'),
+    buildStatusString(1, 0, 0, 'a ${tests[5]}', count: 0, setup: '',
+        teardown: 'teardown'),
+    buildStatusString(1, 0, 0, 'a ${tests[6]}', count: 0,
+        setup: 'setup', teardown: 'teardown'),
+    buildStatusString(1, 0, 0, tests[7], count: 1),
+    buildStatusString(0, 0, 1, tests[8], count: 1,
         message: 'Callback called more times than expected (2 > 1).'),
-    buildStatusString(1, 0, 0, tests[9], 10),
+    buildStatusString(1, 0, 0, tests[9], count: 10),
     buildStatusString(0, 1, 0, tests[10], message: 'Caught error!'),
     buildStatusString(1, 0, 1, 'testOne', message: 'Callback called after already being marked as done (1).:testTwo:'),
     buildStatusString(2, 1, 0, 'testOne::testTwo:Expected: false but: was <true>.:testThree')
   ];
 
   actual = [];
 
   nextTest(0);
 }