Second round of cleanups for new optional parameter semantics.

pkg/intl/test/bidi_utils_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 #library('bidi_utils_test');
 
 #import('../lib/intl.dart');
 #import('../../../pkg/unittest/unittest.dart');
 
@@ skipping 167 matching lines @@
   });
 
   test('normalizeHebrewQuote', () {
     expect(Bidi.normalizeHebrewQuote('\u05d0"'), equals('\u05d0\u05f4'));
     expect(Bidi.normalizeHebrewQuote('\u05d0\''), equals('\u05d0\u05f3'));
     expect(Bidi.normalizeHebrewQuote('\u05d0"\u05d0\''),
         equals('\u05d0\u05f4\u05d0\u05f3'));
   });
 
   test('estimateDirectionOfText', () {
-    expect(Bidi.estimateDirectionOfText('', false).value,
+    expect(Bidi.estimateDirectionOfText('', isHtml: false).value,
         equals(TextDirection.UNKNOWN.value));
-    expect(Bidi.estimateDirectionOfText(' ', false).value,
+    expect(Bidi.estimateDirectionOfText(' ', isHtml: false).value,
         equals(TextDirection.UNKNOWN.value));
-    expect(Bidi.estimateDirectionOfText('! (...)', false).value,
+    expect(Bidi.estimateDirectionOfText('! (...)', isHtml: false).value,
         equals(TextDirection.UNKNOWN.value));
-    expect(Bidi.estimateDirectionOfText('All-Ascii content', false).value,
+    expect(Bidi.estimateDirectionOfText('All-Ascii content',
+                                        isHtml: false).value,
         equals(TextDirection.LTR.value));
-    expect(Bidi.estimateDirectionOfText('-17.0%', false).value,
+    expect(Bidi.estimateDirectionOfText('-17.0%', isHtml: false).value,
         equals(TextDirection.LTR.value));
-    expect(Bidi.estimateDirectionOfText('http://foo/bar/', false).value,
+    expect(Bidi.estimateDirectionOfText('http://foo/bar/', isHtml: false).value,
         equals(TextDirection.LTR.value));
     expect(Bidi.estimateDirectionOfText(
         'http://foo/bar/?s=\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0'
         '\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0\u05d0'
         '\u05d0\u05d0\u05d0\u05d0\u05d0').value,
         equals(TextDirection.LTR.value));
-    expect(Bidi.estimateDirectionOfText('\u05d0', false).value,
+    expect(Bidi.estimateDirectionOfText('\u05d0', isHtml: false).value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
-        '9 \u05d0 -> 17.5, 23, 45, 19', false).value,
+        '9 \u05d0 -> 17.5, 23, 45, 19', isHtml: false).value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         'http://foo/bar/ \u05d0 http://foo2/bar2/ http://foo3/bar3/').value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         '\u05d0\u05d9\u05df \u05de\u05de\u05e9 \u05de\u05d4 \u05dc\u05e8\u05d0'
         '\u05d5\u05ea: \u05dc\u05d0 \u05e6\u05d9\u05dc\u05de\u05ea\u05d9 \u05d4'
         '\u05e8\u05d1\u05d4 \u05d5\u05d2\u05dd \u05d0\u05dd \u05d4\u05d9\u05d9'
         '\u05ea\u05d9 \u05de\u05e6\u05dc\u05dd, \u05d4\u05d9\u05d4 \u05e9'
         '\u05dd').value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         '\u05db\u05d0 - http://geek.co.il/gallery/v/2007-06 - \u05d0\u05d9'
         '\u05df \u05de\u05de\u05e9 \u05de\u05d4 \u05dc\u05e8\u05d0\u05d5\u05ea:'
         ' \u05dc\u05d0 \u05e6\u05d9\u05dc\u05de\u05ea\u05d9 \u05d4\u05e8\u05d1 '
         '\u05d5\u05d2\u05dd \u05d0\u05dd \u05d4\u05d9\u05d9\u05d9 \u05de\u05e6'
         '\u05dc\u05dd, \u05d4\u05d9\u05d4 \u05e9\u05dd \u05d1\u05e2\u05d9\u05e7'
         ' \u05d4\u05e8\u05d1\u05d4 \u05d0\u05e0\u05e9\u05d9\u05dd. \u05de\u05d4'
         ' \u05e9\u05db\u05df - \u05d0\u05e4\u05e9\u05e8 \u05dc\u05e0\u05e6'
         '\u05dc \u05d0\u05ea \u05d4\u05d4 \u05d3\u05d6\u05de\u05e0\u05d5 '
         '\u05dc\u05d4\u05e1\u05ea\u05db\u05dc \u05e2\u05dc \u05db\u05de\u05d4 '
         '\u05ea\u05de\u05d5\u05e0\u05d5\u05ea \u05de\u05e9\u05e9\u05e2\u05d5'
         '\u05ea \u05d9\u05e9\u05e0\u05d5 \u05d9\u05d5\u05ea\u05e8 \u05e9\u05d9'
-        '\u05e9 \u05dc\u05d9 \u05d1\u05d0\u05ea\u05e8', false).value,
+        '\u05e9 \u05dc\u05d9 \u05d1\u05d0\u05ea\u05e8', isHtml: false).value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         'CAPTCHA \u05de\u05e9\u05d5\u05db\u05dc\u05dc '
         '\u05de\u05d3\u05d9?').value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         'Yes Prime Minister \u05e2\u05d3\u05db\u05d5\u05df. \u05e9\u05d0\u05dc'
         '\u05d5 \u05d0\u05d5\u05ea\u05d9 \u05de\u05d4 \u05d0\u05e0\u05d9 '
         '\u05e8\u05d5\u05e6\u05d4 \u05de\u05ea\u05e0\u05d4 \u05dc\u05d7'
         '\u05d2').value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         '17.4.02 \u05e9\u05e2\u05d4:13-20 .15-00 .\u05dc\u05d0 \u05d4\u05d9'
         '\u05d9\u05ea\u05d9 \u05db\u05d0\u05df.').value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         '5710 5720 5730. \u05d4\u05d3\u05dc\u05ea. \u05d4\u05e0\u05e9\u05d9'
-        '\u05e7\u05d4', false).value,
+        '\u05e7\u05d4', isHtml: false).value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         '\u05d4\u05d3\u05dc\u05ea http://www.google.com '
         'http://www.gmail.com').value,
         equals(TextDirection.RTL.value));
     expect(Bidi.estimateDirectionOfText(
         '\u05d4\u05d3\u05dc <some quite nasty html mark up>').value,
         equals(TextDirection.LTR.value));
     expect(Bidi.estimateDirectionOfText(
         '\u05d4\u05d3\u05dc <some quite nasty html mark up>').value,
         equals(TextDirection.LTR.value));
     expect(Bidi.estimateDirectionOfText(
         '\u05d4\u05d3\u05dc\u05ea &amp; &lt; &gt;').value,
         equals(TextDirection.LTR.value));
     expect(Bidi.estimateDirectionOfText(
-        '\u05d4\u05d3\u05dc\u05ea &amp; &lt; &gt;', true).value,
+        '\u05d4\u05d3\u05dc\u05ea &amp; &lt; &gt;', isHtml: true).value,
         equals(TextDirection.RTL.value));
   });
 
   test('detectRtlDirectionality', () {
     var bidiText = [];
     var item = new SampleItem('Pure Ascii content');
     bidiText.add(item);
 
     item = new SampleItem('\u05d0\u05d9\u05df \u05de\u05de\u05e9 \u05de\u05d4'
         ' \u05dc\u05e8\u05d0\u05d5\u05ea: \u05dc\u05d0 \u05e6\u05d9\u05dc'
@@ skipping 41 matching lines @@
     bidiText.add(item);
 
     item = new SampleItem('&gt;\u05d4&lt;', true, true);
     bidiText.add(item);
 
     item = new SampleItem('&gt;\u05d4&lt;', false);
     bidiText.add(item);
 
     for (var i = 0; i < bidiText.length; i++) {
         var isRtlDir = Bidi.detectRtlDirectionality(bidiText[i].text,
-                                                            bidiText[i].isHtml);
+                                                    isHtml: bidiText[i].isHtml);
       if (isRtlDir != bidiText[i].isRtl) {
         var str = '"${bidiText[i].text} " should be '
                   '${bidiText[i].isRtl ? "rtl" : "ltr"} but detected as '
                   '${isRtlDir ? "rtl" : "ltr"}';
         //alert(str);
       }
       expect(bidiText[i].isRtl, isRtlDir);
     }
   });
 }
 
 class SampleItem {
   String text;
   bool isRtl;
   bool isHtml;
   SampleItem([someText='', someIsRtl=false, isHtml=false]) :
       this.text=someText, this.isRtl=someIsRtl, this.isHtml=isHtml;
 }