Second round of cleanups for new optional parameter semantics.

pkg/intl/lib/bidi_utils.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Bidi stands for Bi-directional text.
  * According to http://en.wikipedia.org/wiki/Bi-directional_text:
  * Bi-directional text is text containing text in both text directionalities,
  * both right-to-left (RTL) and left-to-right (LTR). It generally involves text
  * containing different types of alphabets, but may also refer to boustrophedon,
@@ skipping 297 matching lines @@
    * general-purpose method (using relative word counts). A
    * TextDirection.UNKNOWN return value indicates completely neutral input.
    * [isHtml] is true if [text] HTML or HTML-escaped.
    *
    * If the number of RTL words is above a certain percentage of the total
    * number of strongly directional words, returns RTL.
    * Otherwise, if any words are strongly or weakly LTR, returns LTR.
    * Otherwise, returns UNKNOWN, which is used to mean `neutral`.
    * Numbers and URLs are counted as weakly LTR.
    */
-  static TextDirection estimateDirectionOfText(String text, [bool isHtml=false]) {
+  static TextDirection estimateDirectionOfText(String text,
+                                               {bool isHtml: false}) {
     text = isHtml? stripHtmlIfNeeded(text) : text;
     var rtlCount = 0;
     var total = 0;
     var hasWeaklyLtr = false;
     // Split a string into 'words' for directionality estimation based on
     // relative word counts.
     for (String token in text.split(const RegExp(r'\s+'))) {
       if (startsWithRtl(token)) {
         rtlCount++;
         total++;
@@ skipping 57 matching lines @@
       }
     }
     return buf.toString();
   }
 
   /**
    * Check the estimated directionality of [str], return true if the piece of
    * text should be laid out in RTL direction. If [isHtml] is true, the string
    * is HTML or HTML-escaped.
    */
-  static bool detectRtlDirectionality(String str, [bool isHtml]) {
-    return estimateDirectionOfText(str, isHtml) == TextDirection.RTL;
+  static bool detectRtlDirectionality(String str, {bool isHtml}) {

[Lasse Reichstein Nielsen, 2012/10/17 14:56:10]

Give it a default value of false, instead of relying on null being falsy.

[regis, 2012/10/17 19:58:16]

Done. But I need to postpone these changes in bidi_util, because of an apparent
bug in dart2js. I'll file a bug.

+    return estimateDirectionOfText(str, isHtml: isHtml) == TextDirection.RTL;
   }
 }