Chromium Code Reviews| Index: chrome/browser/resources/print_preview/previewarea/preview_area.js |
| diff --git a/chrome/browser/resources/print_preview/previewarea/preview_area.js b/chrome/browser/resources/print_preview/previewarea/preview_area.js |
| index 8e996703475ac79f9c8819307fb008847e10409c..102b026f8a6beb2932c72f1b25071e078f1a468f 100644 |
| --- a/chrome/browser/resources/print_preview/previewarea/preview_area.js |
| +++ b/chrome/browser/resources/print_preview/previewarea/preview_area.js |
| @@ -150,8 +150,7 @@ cr.define('print_preview', function() { |
| OPEN_SYSTEM_DIALOG_BUTTON: 'preview-area-open-system-dialog-button', |
| OPEN_SYSTEM_DIALOG_BUTTON_THROBBER: |
| 'preview-area-open-system-dialog-button-throbber', |
| - OVERLAY: 'preview-area-overlay-layer', |
| - PDF_PLUGIN: 'preview-area-pdf-plugin' |
|
ydolgov1
2012/10/16 21:44:54
Not sure I understand why you removed this class f
Toscano
2012/10/16 22:24:14
This class was no longer used. So I removed it. Bu
|
| + OVERLAY: 'preview-area-overlay-layer' |
| }; |
| /** |
| @@ -418,7 +417,8 @@ cr.define('print_preview', function() { |
| this.plugin_.setAttribute('src', srcUrl); |
| this.plugin_.setAttribute('aria-live', 'polite'); |
| this.plugin_.setAttribute('aria-atomic', 'true'); |
| - this.getElement().appendChild(this.plugin_); |
| + this.getChildElement('.preview-area-plugin-wrapper'). |
|
ydolgov1
2012/10/16 22:43:17
Do you have any rule when you use getChildElement
Toscano
2012/10/16 22:58:44
Yes. Always use getChildElement. I want to move aw
|
| + appendChild(this.plugin_); |
| global['onPreviewPluginLoad'] = this.onPluginLoad_.bind(this); |
| this.plugin_.onload('onPreviewPluginLoad()'); |