Creates GCP promo for ChromeOS users with no cloud printers.

chrome/browser/resources/print_preview/data/app_state.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Object used to get and persist the print preview application state.
    * @constructor
@@ skipping 54 matching lines @@
      * @private
      */
     this.isLandscapeEnabled_ = null;
 
     /**
      * Whether printing collation is enabled.
      * @type {?boolean}
      * @private
      */
     this.isCollateEnabled_ = null;
+
+    /**
+     * Whether the GCP promotion has been dismissed.
+     * @type {boolean}
+     * @private
+     */
+    this.isGcpPromoDismissed_ = true;

[ydolgov1, 2012/10/16 21:44:54]

Why is it true by default? Should we initialize it with null as we do for other
boolean fields?

[ydolgov1, 2012/10/16 21:44:54]

And also can you move it closer to selectedDestinationId_ just to keep all the
global application properties together.

[Toscano, 2012/10/16 22:24:14]

I'd like to keep the default behavior to not show the promo. This actually
solves a small bug where the the cloud print requests finish before the AppState
is initialized resulting in the promo flashing on and off for a split second.

[Toscano, 2012/10/16 22:24:14]

Done.

   };
 
   /**
    * Current version of the app state. This value helps to understand how to
    * parse earlier versions of the app state.
    * @type {number}
    * @const
    * @private
    */
   AppState.VERSION_ = 2;
 
   /**
    * Enumeration of field names for serialized app state.
    * @enum {string}
    * @private
    */
   AppState.Field_ = {
     VERSION: 'version',
     SELECTED_DESTINATION_ID: 'selectedDestinationId',
     IS_SELECTED_DESTINATION_LOCAL: 'isSelectedDestinationLocal',
     MARGINS_TYPE: 'marginsType',
     CUSTOM_MARGINS: 'customMargins',
     IS_COLOR_ENABLED: 'isColorEnabled',
     IS_DUPLEX_ENABLED: 'isDuplexEnabled',
     IS_HEADER_FOOTER_ENABLED: 'isHeaderFooterEnabled',
     IS_LANDSCAPE_ENABLED: 'isLandscapeEnabled',
-    IS_COLLATE_ENABLED: 'isCollateEnabled'
+    IS_COLLATE_ENABLED: 'isCollateEnabled',
+    IS_GCP_PROMO_DISMISSED: 'isGcpPromoDismissed'
   };
 
   /**
    * Name of C++ layer function to persist app state.
    * @type {string}
    * @const
    * @private
    */
   AppState.NATIVE_FUNCTION_NAME_ = 'saveAppState';
 
@@ skipping 36 matching lines @@
     /** @return {?boolean} Whether landscape page orientation is selected. */
     get isLandscapeEnabled() {
       return this.isLandscapeEnabled_;
     },
 
     /** @return {?boolean} Whether printing collation is enabled. */
     get isCollateEnabled() {
       return this.isCollateEnabled_;
     },
 
+    /** @return {boolean} Whether the GCP promotion has been dismissed. */

[ydolgov1, 2012/10/16 22:43:17]

Can you also move this one closer to isSelectedDestinationLocal?

[Toscano, 2012/10/16 22:58:44]

Done.

+    get isGcpPromoDismissed() {
+      return this.isGcpPromoDismissed_;
+    },
+
     /**
      * Initializes the app state from a serialized string returned by the native
      * layer.
      * @param {?string} serializedAppStateStr Serialized string representation
      *     of the app state.
      */
     init: function(serializedAppStateStr) {
       if (!serializedAppStateStr) {
         return;
       }
@@ skipping 24 matching lines @@
           this.isHeaderFooterEnabled_ =
               state[AppState.Field_.IS_HEADER_FOOTER_ENABLED];
         }
         if (state.hasOwnProperty(AppState.Field_.IS_LANDSCAPE_ENABLED)) {
           this.isLandscapeEnabled_ =
               state[AppState.Field_.IS_LANDSCAPE_ENABLED];
         }
         if (state.hasOwnProperty(AppState.Field_.IS_COLLATE_ENABLED)) {
           this.isCollateEnabled_ = state[AppState.Field_.IS_COLLATE_ENABLED];
         }
+        this.isGcpPromoDismissed_ =

[ydolgov1, 2012/10/16 22:43:17]

And this closer to "this.selectedDestinationId_ =..."?

[Toscano, 2012/10/16 22:58:44]

Done.

+            state[AppState.Field_.IS_GCP_PROMO_DISMISSED] || false;
       }
     },
 
     /**
      * Persists the selected destination.
      * @param {!print_preview.Destination} dest Destination to persist.
      */
     persistSelectedDestination: function(dest) {
       this.selectedDestinationId_ = dest.id;
       this.isSelectedDestinationLocal_ = dest.isLocal;
@@ skipping 58 matching lines @@
     /**
      * Persists whether printing collation is enabled.
      * @param {?boolean} isCollateEnabled Whether printing collation is enabled.
      */
     persistIsCollateEnabled: function(isCollateEnabled) {
       this.isCollateEnabled_ = isCollateEnabled;
       this.persist_();
     },
 
     /**
+     * Persists whether the GCP promotion has been dismissed.
+     * @param {boolean} isGcpPromoDismissed Whether the GCP promotion has been
+     *     dismissed.
+     */
+   persistIsGcpPromoDismissed: function(isGcpPromoDismissed) {

[ydolgov1, 2012/10/16 22:43:17]

Please fix indentation.

[Toscano, 2012/10/16 22:58:44]

Done.

+     this.isGcpPromoDismissed_ = isGcpPromoDismissed;
+     this.persist_();
+   },
+
+    /**
      * Calls into the native layer to persist the application state.
      * @private
      */
     persist_: function() {
       var obj = {};
       obj[AppState.Field_.VERSION] = AppState.VERSION_;
       obj[AppState.Field_.SELECTED_DESTINATION_ID] =
           this.selectedDestinationId_;
       obj[AppState.Field_.IS_SELECTED_DESTINATION_LOCAL] =
           this.isSelectedDestinationLocal_;
       obj[AppState.Field_.MARGINS_TYPE] = this.marginsType_;
       if (this.customMargins_) {
         obj[AppState.Field_.CUSTOM_MARGINS] = this.customMargins_.serialize();
       }
       obj[AppState.Field_.IS_COLOR_ENABLED] = this.isColorEnabled_;
       obj[AppState.Field_.IS_DUPLEX_ENABLED] = this.isDuplexEnabled_;
       obj[AppState.Field_.IS_HEADER_FOOTER_ENABLED] =
           this.isHeaderFooterEnabled_;
       obj[AppState.Field_.IS_LANDSCAPE_ENABLED] = this.isLandscapeEnabled_;
       obj[AppState.Field_.IS_COLLATE_ENABLED] = this.isCollateEnabled_;
+      obj[AppState.Field_.IS_GCP_PROMO_DISMISSED] = this.isGcpPromoDismissed_;

[ydolgov1, 2012/10/16 22:43:17]

And also please move this one closer to
"obj[AppState.Field_.SELECTED_DESTINATION_ID]..."

[Toscano, 2012/10/16 22:58:44]

Done.

       chrome.send(AppState.NATIVE_FUNCTION_NAME_, [JSON.stringify(obj)]);
     }
   };
 
   return {
     AppState: AppState
   };
 });