Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 11194011: Reverting this CL because it was committed before I gave the final LGTM. (Closed)

Created:
8 years, 2 months ago by Ben Goodger (Google)
Modified:
8 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Reverting this CL because it was committed before I gave the final LGTM. Revert 162142 - Full Screen Magnifier: Add MagnificationManager MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side). MagnificationManager does: - Watch logged-in. Change the behavior between the login screen and user desktop. - Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it. In addition, this patch make the magnifier settings per-user instead of per-device. BUG=151891 TEST=manual, browser_test passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162080 Review URL: https://chromiumcodereview.appspot.com/11065008 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -364 lines) Patch
M ash/magnifier/magnification_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 3 chunks +13 lines, -5 lines 0 comments Download
D chrome/browser/chromeos/accessibility/magnification_manager.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +5 lines, -0 lines 0 comments Download
MM chrome/browser/chromeos/preferences.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +10 lines, -8 lines 0 comments Download
MM chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +5 lines, -7 lines 0 comments Download
MM chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Goodger (Google)
8 years, 2 months ago (2012-10-16 19:29:51 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698