Issue 1119353002: Revert of Move state management to GrInOrderDrawBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1119353002: Revert of Move state management to GrInOrderDrawBuffer (Closed)

Created:
5 years, 7 months ago by joshualitt

Modified:
5 years, 7 months ago

Reviewers:
bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@batchownsbounds

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Move state management to GrInOrderDrawBuffer (patchset #4 id:60001 of https://codereview.chromium.org/1120143002/) Reason for revert: Breaks windows Original issue's description: > Move state management to GrInOrderDrawBuffer > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/5d6bb6f795143ca360b868560b52165de51fa269 TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/edae3096afe674efce917825f8d44726037405eb

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+254 lines, -238 lines)			Patch
M	src/gpu/GrAtlasTextContext.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	3 chunks	+1 line, -23 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	9 chunks	+11 lines, -82 lines	0 comments	Download
M	src/gpu/GrTargetCommands.h	View	13 chunks	+89 lines, -87 lines	0 comments	Download
M	src/gpu/GrTargetCommands.cpp	View	16 chunks	+152 lines, -46 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of Move state management to GrInOrderDrawBuffer

5 years, 7 months ago (2015-05-04 14:50:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119353002/1

5 years, 7 months ago (2015-05-04 14:51:00 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-04 14:51:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/edae3096afe674efce917825f8d44726037405eb