Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 111933005: Fix Java style issues in sync/android (Closed)

Created:
7 years ago by aurimas (slooooooooow)
Modified:
7 years ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Fix Java style issues in sync/android BUG=320711 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240260

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -84 lines) Patch
M sync/android/java/src/org/chromium/sync/internal_api/pub/SyncDecryptionPassphraseType.java View 1 chunk +9 lines, -9 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationClientNameGenerator.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationClientNameProvider.java View 1 chunk +4 lines, -4 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java View 2 chunks +20 lines, -20 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/InvalidationService.java View 3 chunks +15 lines, -15 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/SyncContentResolverDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/SystemSyncContentResolverDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/AccountManagerDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java View 5 chunks +8 lines, -8 lines 3 comments Download
M sync/android/java/src/org/chromium/sync/signin/SystemAccountManagerDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/javatests/src/org/chromium/sync/notifier/InvalidationPreferencesTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/android/javatests/src/org/chromium/sync/notifier/InvalidationServiceTest.java View 3 chunks +13 lines, -13 lines 0 comments Download
M sync/android/javatests/src/org/chromium/sync/notifier/TestableInvalidationService.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/android/javatests/src/org/chromium/sync/notifier/signin/SyncStatusHelperTest.java View 1 chunk +1 line, -1 line 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
aurimas (slooooooooow)
Hey Tommy, Please take a look at this CL. Thanks, Aurimas
7 years ago (2013-12-11 15:55:25 UTC) #1
nyquist
lgtm, but I thought we usually didn't update copyright headers? https://codereview.chromium.org/111933005/diff/1/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java File sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java (right): https://codereview.chromium.org/111933005/diff/1/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java#newcode45 ...
7 years ago (2013-12-12 01:29:12 UTC) #2
aurimas (slooooooooow)
https://codereview.chromium.org/111933005/diff/1/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java File sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java (right): https://codereview.chromium.org/111933005/diff/1/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java#newcode45 sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java:45: private static final Object sLock = new Object(); On ...
7 years ago (2013-12-12 01:36:57 UTC) #3
nyquist
https://codereview.chromium.org/111933005/diff/1/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java File sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java (right): https://codereview.chromium.org/111933005/diff/1/sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java#newcode45 sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java:45: private static final Object sLock = new Object(); On ...
7 years ago (2013-12-12 02:03:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/111933005/1
7 years ago (2013-12-12 02:03:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/111933005/1
7 years ago (2013-12-12 02:16:48 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-12 07:44:52 UTC) #7
Message was sent while issue was closed. 
Change committed as 240260

Powered by Google App Engine
This is Rietveld 408576698