Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 11193024: The snapshot buffer was being released too early resulting in weird crashes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/gen_snapshot.cc
===================================================================
--- runtime/bin/gen_snapshot.cc (revision 13746)
+++ runtime/bin/gen_snapshot.cc (working copy)
@@ -357,7 +357,6 @@
snapshot_buffer,
NULL,
&error);
- free(snapshot_buffer);
if (isolate == NULL) {
fprintf(stderr, "%s", error);
free(error);
Ivan Posva 2012/10/18 05:45:52 "Leaking" the snapshot_buffer here.
siva 2012/10/18 17:55:43 Fixing in a new CL. On 2012/10/18 05:45:52, Ivan
@@ -384,6 +383,8 @@
// Now create and write snapshot of script.
CreateAndWriteSnapshot(true);
+
+ free(snapshot_buffer);
}
} else {
SetupForGenericSnapshotCreation();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698