Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11193020: Revert recent CPU profiler changes because they broke --prof. (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow
Modified:
8 years, 2 months ago
Reviewers:
Massi
CC:
v8-dev, caseq
Visibility:
Public.

Description

Revert recent CPU profiler changes because they broke --prof. This reverts r12649 and r12650. BUG=v8:2364 Committed: https://code.google.com/p/v8/source/detail?r=12745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -233 lines) Patch
M src/cpu-profiler.h View 4 chunks +8 lines, -20 lines 0 comments Download
M src/cpu-profiler.cc View 7 chunks +40 lines, -50 lines 0 comments Download
M src/cpu-profiler-inl.h View 2 chunks +5 lines, -11 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/platform.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/platform-cygwin.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M src/platform-freebsd.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M src/platform-linux.cc View 10 chunks +77 lines, -74 lines 0 comments Download
M src/platform-macos.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M src/platform-openbsd.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M src/platform-solaris.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M src/platform-win32.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 10 chunks +18 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
Massi: PTAL. Andrey: FYI.
8 years, 2 months ago (2012-10-17 12:12:49 UTC) #1
Massi
8 years, 2 months ago (2012-10-17 12:20:45 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698