settings: fix search

settings: fix search

don't reference an element that doesn't exist. A button was removed in r160703, but it was still listed as an "associated control" for search, so that during search NULL was derefed.

BUG=155364
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162307

[Evan Stade, 2012-10-16 22:13:58]

dbeam review, mkwst FYI. Needs to be merged to 1271 (m23).

[Dan Beam, 2012-10-16 22:25:47]

lgtm

[Dan Beam, 2012-10-16 22:27:44]

http://codereview.chromium.org/11193013/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options/options_page.js (right):

http://codereview.chromium.org/11193013/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options/options_page.js:504: // Sanity check.
it's possible that you'd wrap this in an <if expr="debug"> 
(or however you do that in .js), but it just depends on how much you expect
users to hit this / help you repro

[Dan Beam, 2012-10-16 22:28:30]

On 2012/10/16 22:27:44, Dan Beam wrote:
>
http://codereview.chromium.org/11193013/diff/1/chrome/browser/resources/optio...
> File chrome/browser/resources/options/options_page.js (right):
> 
>
http://codereview.chromium.org/11193013/diff/1/chrome/browser/resources/optio...
> chrome/browser/resources/options/options_page.js:504: // Sanity check.
> it's possible that you'd wrap this in an <if expr="debug"> 
> (or however you do that in .js), but it just depends on how much you expect
> users to hit this / help you repro

it'd also depend on there being a debug or ndebug being passed to this layer
(don't know if we do that currently)

[Evan Stade, 2012-10-16 22:57:39]

https://chromiumcodereview.appspot.com/11193013/diff/1/chrome/browser/resourc...
File chrome/browser/resources/options/options_page.js (right):

https://chromiumcodereview.appspot.com/11193013/diff/1/chrome/browser/resourc...
chrome/browser/resources/options/options_page.js:504: // Sanity check.
On 2012/10/16 22:27:45, Dan Beam wrote:
> it's possible that you'd wrap this in an <if expr="debug"> 
> (or however you do that in .js), but it just depends on how much you expect
> users to hit this / help you repro

since registerOverlay is called at startup, this completely breaks the page on
load. Developers can't help but notice it before it gets to users.