Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 11193007: Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode… (Closed)

Created:
8 years, 2 months ago by ananta
Modified:
8 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a crash seen at times when chrome in desktop mode attempts to activate Chrome in Windows 8 mode. The crash occurs because we attempt to initiate a navigation when there are no frame windows registered with the metro driver. Fix is to ignore the navigation request in this case. I also updated the ChromeUrlLaunchHandler::GetUrlFromLaunchArgs function to return the chrome://newtab url if the verb coming in is opennewwindow. This should address bug http://code.google.com/p/chromium/issues/detail?id=135122 BUG=155281, 135122 R=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162269

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M win8/metro_driver/chrome_url_launch_handler.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
8 years, 2 months ago (2012-10-16 19:23:11 UTC) #1
cpu_(ooo_6.6-7.5)
8 years, 2 months ago (2012-10-16 21:55:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698