Add third batch of controlled setting indicators

Add third batch of controlled setting indicators

This CL continues the addition of controlled setting indicators to
the Chrome settings UI. It also refactors the policy_prefs_browsertest
and its test cases definition file so that a single policy mapping to
multiple prefs can be tested.

BUG=104955
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162975

[bartfab (slow), 2012-10-16 16:33:18]

Hi James, could you review the UI side please?
Hi Joao, could you review the refactored browser tests please?

[Joao da Silva, 2012-10-16 17:58:41]

policy/ changes lgtm. Please see comments inline.

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/...
File chrome/browser/policy/policy_prefs_browsertest.cc (right):

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/...
chrome/browser/policy/policy_prefs_browsertest.cc:285: continue;
add a failure if the input is broken

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/...
chrome/browser/policy/policy_prefs_browsertest.cc:303: continue;
add failure

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/resourc...
File chrome/browser/resources/options/browser_options.html (right):

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.html:262: <label
for="safeBrowskingEnabled">
typo, safeBrowsingEnabled

[bartfab (slow), 2012-10-16 20:50:30]

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/...
File chrome/browser/policy/policy_prefs_browsertest.cc (right):

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/...
chrome/browser/policy/policy_prefs_browsertest.cc:285: continue;
On 2012/10/16 17:58:41, Joao da Silva wrote:
> add a failure if the input is broken

Done.

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/policy/...
chrome/browser/policy/policy_prefs_browsertest.cc:303: continue;
On 2012/10/16 17:58:41, Joao da Silva wrote:
> add failure

Done.

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/resourc...
File chrome/browser/resources/options/browser_options.html (right):

https://chromiumcodereview.appspot.com/11193002/diff/1/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.html:262: <label
for="safeBrowskingEnabled">
Nice catch, thanks.
Done.

[James Hawkins, 2012-10-17 03:29:28]

https://chromiumcodereview.appspot.com/11193002/diff/2007/chrome/browser/reso...
File chrome/browser/resources/options/browser_options.html (right):

https://chromiumcodereview.appspot.com/11193002/diff/2007/chrome/browser/reso...
chrome/browser/resources/options/browser_options.html:263: <span
i18n-content="safeBrowsingEnableProtection"></span>
Just set the i18n-content of the label element.

[bartfab (slow), 2012-10-18 13:05:04]

https://codereview.chromium.org/11193002/diff/2007/chrome/browser/resources/o...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/11193002/diff/2007/chrome/browser/resources/o...
chrome/browser/resources/options/browser_options.html:263: <span
i18n-content="safeBrowsingEnableProtection"></span>
On 2012/10/17 03:29:28, James Hawkins wrote:
> Just set the i18n-content of the label element.

Done.

[James Hawkins, 2012-10-18 16:34:18]

lgtm

[commit-bot: I haz the power, 2012-10-19 07:54:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/11193002/10001

[commit-bot: I haz the power, 2012-10-19 09:51:31]

Change committed as 162975