Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1119263002: X87: VectorICs: built-in function apply should use an IC. (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: VectorICs: built-in function apply should use an IC. port 83a0af55009548238a2ff6ef71c3387a49da0a88 (r28165). original commit message: VectorICs: built-in function apply should use an IC. Handled a TODO that sent builtin function apply to the runtime on property get. BUG= Committed: https://crrev.com/d09e119bc4f14cc5d7eefb0bad20d4eeef3c42a4 Cr-Commit-Position: refs/heads/master@{#28189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +7 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 7 months ago (2015-05-04 02:45:50 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-04 03:18:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119263002/1
5 years, 7 months ago (2015-05-04 03:18:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-04 03:40:28 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 03:40:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d09e119bc4f14cc5d7eefb0bad20d4eeef3c42a4
Cr-Commit-Position: refs/heads/master@{#28189}

Powered by Google App Engine
This is Rietveld 408576698