[Android] Add supportMultipleWindows setting

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 2400 matching lines @@
 }
 
 // We are supposed to get a single call to Show for a newly created RenderView
 // that was created via RenderViewImpl::CreateWebView.  So, we wait until this
 // point to dispatch the ShowView message.
 //
 // This method provides us with the information about how to display the newly
 // created RenderView (i.e., as a blocked popup or as a new tab).
 //
 void RenderViewImpl::show(WebNavigationPolicy policy) {
+#if !defined(OS_ANDROID)

[joth, 2012/10/18 20:06:00]

Maybe easier to follow as:

if (did_show_) {
#if defined(OS_ANDROID)
  if (webkit_preferences_.support_multiple_windows)
    return;
#endif
  NOTREACHED();  // received extraneous show call
  return;
}
did_show_ = true;

[mnaganov (inactive), 2012/10/19 15:46:39]

Changed to an alternative shorter version.

[mnaganov (inactive), 2012/10/19 16:22:56]

Ouch. My approach doesn't always compile, changing to yours.

   DCHECK(!did_show_) << "received extraneous Show call";
-  DCHECK(opener_id_ != MSG_ROUTING_NONE);
+#else
+  DCHECK(!did_show_ || !webkit_preferences_.support_multiple_windows) <<
+      "received extraneous Show call";
+#endif
 
   if (did_show_)
     return;
   did_show_ = true;
 
+  DCHECK(opener_id_ != MSG_ROUTING_NONE);
+
   if (content::GetContentClient()->renderer()->AllowPopup(creator_url_))
     opened_by_user_gesture_ = true;
 
   // Force new windows to a popup if they were not opened with a user gesture.
   if (!opened_by_user_gesture_) {
     // We exempt background tabs for compat with older versions of Chrome.
     // TODO(darin): This seems bogus.  These should have a user gesture, so
     // we probably don't need this check.
     if (policy != WebKit::WebNavigationPolicyNewBackgroundTab)
       policy = WebKit::WebNavigationPolicyNewPopup;
@@ skipping 3991 matching lines @@
                                                transport_dib->id()));
 
   return true;
 }
 
 void RenderViewImpl::OnReleaseDisambiguationPopupDIB(
     TransportDIB::Handle dib_handle) {
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }