[Android] Add supportMultipleWindows setting

content/public/android/java/src/org/chromium/content/browser/ContentSettings.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.os.Handler;
 import android.os.Looper;
 import android.os.Message;
 import android.webkit.WebSettings.PluginState;
@@ skipping 55 matching lines @@
     private int mMinimumFontSize = 8;
     private int mMinimumLogicalFontSize = 8;
     private int mDefaultFontSize = 16;
     private int mDefaultFixedFontSize = 13;
     private boolean mLoadsImagesAutomatically = true;
     private boolean mImagesEnabled = true;
     private boolean mJavaScriptEnabled = false;
     private boolean mAllowUniversalAccessFromFileURLs = false;
     private boolean mAllowFileAccessFromFileURLs = false;
     private boolean mJavaScriptCanOpenWindowsAutomatically = false;
+    private boolean mSupportMultipleWindows = false;
     private PluginState mPluginState = PluginState.OFF;
     private boolean mDomStorageEnabled = false;
 
     // Not accessed by the native side.
     private String mDefaultUserAgent = "";
     private boolean mSupportZoom = true;
     private boolean mBuiltInZoomControls = false;
     private boolean mDisplayZoomControls = true;
 
     // Class to handle messages to be processed on the UI thread.
@@ skipping 766 matching lines @@
      * @return True if javascript can open windows automatically during
      *         window.open().
      */
     public boolean getJavaScriptCanOpenWindowsAutomatically() {
         synchronized (mContentSettingsLock) {
             return mJavaScriptCanOpenWindowsAutomatically;
         }
     }
 
     /**
+     * Tells the WebView whether it supports multiple windows. TRUE means
+     * that {@link WebChromeClient#onCreateWindow(WebView, boolean,
+     * boolean, Message)} is implemented by the host application.
+     */
+    public synchronized void setSupportMultipleWindows(boolean support) {

[benm (inactive), 2012/10/19 11:02:59]

no need for the synchronized here, we use mContentSettingsLock below

[mnaganov (inactive), 2012/10/19 15:46:39]

Sorry, copied the code from the interface definition. Removed.

+        assert mCanModifySettings;
+        synchronized (mContentSettingsLock) {
+            if (mSupportMultipleWindows != support) {
+                mSupportMultipleWindows = support;
+                mEventHandler.syncSettingsLocked();
+            }
+        }
+    }
+
+    /**
+     * Gets whether the WebView is supporting multiple windows.
+     *
+     * @return true if the WebView is supporting multiple windows. This means
+     *         that {@link WebChromeClient#onCreateWindow(WebView, boolean,
+     *         boolean, Message)} is implemented by the host application.
+     */
+    public synchronized boolean supportMultipleWindows() {
+        synchronized (mContentSettingsLock) {
+            return mSupportMultipleWindows;
+        }
+    }
+
+    /**
      * Sets whether the DOM storage API is enabled. The default value is false.
      *
      * @param flag true if the ContentView should use the DOM storage API
      */
     public void setDomStorageEnabled(boolean flag) {
         assert mCanModifySettings;
         synchronized (mContentSettingsLock) {
             if (mDomStorageEnabled != flag) {
                 mDomStorageEnabled = flag;
                 mEventHandler.syncSettingsLocked();
@@ skipping 71 matching lines @@
     private native int nativeInit(int contentViewPtr, boolean isMasterMode);
 
     private static native String nativeGetDefaultUserAgent();
 
     // Synchronize Java settings from native settings.
     private native void nativeSyncFromNative(int nativeContentSettings);
 
     // Synchronize native settings from Java settings.
     private native void nativeSyncToNative(int nativeContentSettings);
 }